1130408 - Move the deploy script restart-jobs calls outside of the hostgroups loops

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P1)

Description

[Ed Morley [:emorley]]

Broken out from bug 1079270 comment 32.

Comment 1

[Ed Morley [:emorley]]

Attachment: Only call restart-jobs once per hostgroup

Comment 2

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8560593 [details] [review]
Only call restart-jobs once per hostgroup

We might want to move the graceful apache kick over to the restart-jobs script; it shouldn't cause problems as-is, but it's decoupled from the node draining bits and might cause confusion down the road.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/7fa4e973b21f30411e923d9442fec72174d8ae79
Bug 1130408 - deploy: Only call restart-jobs once per hostgroup

The @hostgroups decorator was causing us to call restart-jobs multiple
times (once for each host within a host group), when we only want to
call it once per group of hosts.

Abstracting the restart-jobs call to its own method also means the IRC
bot will output "restart_jobs complete" after each restart-jobs call,
making the progress through the deployment task clearer.

Comment 4

[Ed Morley [:emorley]]

(In reply to Kendall Libby [:fubar] from comment #2)
> We might want to move the graceful apache kick over to the restart-jobs
> script; it shouldn't cause problems as-is, but it's decoupled from the node
> draining bits and might cause confusion down the road.

Yeah agree, I'll file a new bug :-)