1130433 - Create a specific comment when the tree is closed and autolander does not have access

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Description

[Kevin Grandon :kgrandon]

When the tree is closed the autolander bot has it's commit access revoked. It currently comments on bugs with something like, "The pull request could not be applied to the integration branch. Please try again after current integration is complete.". Instead we should have a comment specific to the tree closure, and the fact that it does not have commit access.

Comment 1

[Kevin Grandon :kgrandon]

We may be able to use the collaborators API for this: https://developer.github.com/v3/repos/collaborators/#get

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1130433_notify_when_tree_closed to mozilla:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8560616 [details] [review]
[PullReq] KevinGrandon:bug_1130433_notify_when_tree_closed to mozilla:master

Greg or James - could either of you just take a quick look at this?

If an exception is thrown when trying to merge, I check if the github user (in the config) is a collaborator of the repo or not using the repos.getCollaborator method. If the user is not a collaborator I change the message in the bugzilla comment. Fairly simple, but would appreciate a set of eyes on it. Thanks!

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8560616 [details] [review]
[PullReq] KevinGrandon:bug_1130433_notify_when_tree_closed to mozilla:master

LGTM

Comment 5

[Kevin Grandon :kgrandon]

Oops, forgot to autoland this one :) https://github.com/mozilla/autolander/commit/e70c560f20d6f75397a017ea6fab8fb38f7e0282