1130451 - “Display as” buttons have display issues

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Load MP-dev page https://marketplace-dev.allizom.org/
2. Go to any section that has “Display as” buttons (i.e. https://marketplace-dev.allizom.org/recommended )
3. Click the second button (apps are listed with screenshots)
4. Change the filtering platform (i.e. Desktop Apps)

Expected results:
There are no display issues. The apps available for the selected platform are listed, in their expanded form.

Actual results:
For a few seconds the first “Display as” button appears to be clicked and the apps are listed in their collapsed form.

Notes/Issues:
Verified on MP-dev in FF38(Win 7). This issue is also reproducing on FF OS.
Screencast for this issue: http://screencast.com/t/Gjgbmik9N6lb

Comment 2

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/1014

Comment 3

[Valentina Virlics [:vvalentina], Ecosystem QA]

Te "Display as" buttons have no display issues, but, all apps appear first in the collapse form, even if, the expand form is checked. Is this intended? (http://screencast.com/t/STrQfwoOBBP)

Comment 4

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/1025

Comment 5

[Kevin Ngo [:ngoke]]

reverted due to regression

Comment 6

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/1045

Comment 7

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on FF39(win 7)- http://screencast.com/t/pbtzTXjHsm 
The apps appear in the selected (collapsed/expanded) form, but there is something that I think is not intended: due to the recent changes on the "display as" buttons (the active one is gray and the inactive one is blue) user can obtain different results clicking the same button twice, which is a little bit confusing. 
Please see the screencast: http://screencast.com/t/1HSezpgo

Comment 8

[Davor Spasovski [:spasovski]]

I see no actual issue with the screencast behavior. The buttons are not different (though I suppose they visually may appear that way) it's simply a single toggle switch.

I am tempted to WONTFIX this but I'll let others chime in also.

Comment 9

[Kevin Ngo [:ngoke]]

Valentina, I think that is fine for now. I do agree the toggle is confusing; you can't tell which state is active or not. But this bug can be closed.

Comment 10

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Kevin Ngo [:ngoke] from comment #9)
> Valentina, I think that is fine for now. I do agree the toggle is confusing;
> you can't tell which state is active or not. But this bug can be closed.

Closing bug.