Closed
Bug 1130488
Opened 7 years ago
Closed 7 years ago
Perma orange on comm-central: TEST-UNEXPECTED-TIMEOUT | toolkit/components/downloads/test/unit/test_cancel_download_files_removed.js | Test timed out
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox36 | --- | unaffected |
firefox37 | --- | unaffected |
firefox38 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: jcranmer, Assigned: mkmelin)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(2 files, 1 obsolete file)
2.69 KB,
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
2.24 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
Along with a few other tests. <https://hg.mozilla.org/mozilla-central/rev/afbba6c11b19> is the regressing patch
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 25•7 years ago
|
||
The required fix is outlined in bug 1114624. (I'm excluding this bug from bugmail, please use bug 1114624 or a new one if you need more information.)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•7 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 39•7 years ago
|
||
I think this is it
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
![]() |
||
Comment 40•7 years ago
|
||
(In reply to Magnus Melin from comment #39) > Created attachment 8560996 [details] [diff] [review] > bug1130488_register_legacy_dlmanager.patch > > I think this is it May I suggest you put this in mailGlue.js in a profile-after-change section?
Assignee | ||
Comment 41•7 years ago
|
||
Yeah, the above patch wasn't working
Assignee | ||
Comment 42•7 years ago
|
||
This is probably the correct place yes. I think this makes things work in practice, but tests still fail. This code never gets called there.
Attachment #8560996 -
Attachment is obsolete: true
Assignee | ||
Comment 43•7 years ago
|
||
(someone feel free to take over)
Assignee: mkmelin+mozilla → nobody
![]() |
||
Comment 44•7 years ago
|
||
(In reply to Magnus Melin from comment #42) > Created attachment 8561092 [details] [diff] [review] > bug1130488_register_legacy_dlmanager.patch > > This is probably the correct place yes. > > I think this makes things work in practice, but tests still fail. This code > never gets called there. The following works in SeaMonkey: https://bug1130515.bugzilla.mozilla.org/attachment.cgi?id=8560878 (Please ignore the nsIDownloadManagerUI bits, they are not necessary)
Reporter | ||
Comment 45•7 years ago
|
||
xpcshell tests don't start the profile, hence the profile-after-change never gets called.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 108•7 years ago
|
||
Let's just disable these tests for thunderbird until we drop the legacy download manager. I don't think we can override the Downloads.manifest change (short of backing out 1114624), which is what's causing the problems.
Assignee: nobody → mkmelin+mozilla
Attachment #8563577 -
Flags: review?(paolo.mozmail)
Comment 109•7 years ago
|
||
Comment on attachment 8563577 [details] [diff] [review] mozilla-bug1130488_disable_dl_tests.patch I think it's fine if you want to just disable the xpcshell tests after you fix the component registration. In the tests for the JavaScript API we used to have the registration of the alternative components using the CID in the head.js file, but this might be more work than needed here, and we also plan to remove the old tests anyways.
Attachment #8563577 -
Flags: review?(paolo.mozmail) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 119•7 years ago
|
||
Comment on attachment 8561092 [details] [diff] [review] bug1130488_register_legacy_dlmanager.patch This, minus the dump. I not exactly sure what was broken without this... basic attachment handling seems ok with and without.
Attachment #8561092 -
Flags: review?(philip.chee)
Assignee | ||
Comment 120•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/69f1b692f6fe
Keywords: leave-open
![]() |
||
Comment 121•7 years ago
|
||
Comment on attachment 8561092 [details] [diff] [review] bug1130488_register_legacy_dlmanager.patch > + Components.manager.QueryInterface(Components.interfaces.nsIComponentRegistrar) > + .registerFactory(Components.ID("{1b4c85df-cbdd-4bb6-b04e-613caece083c}"), ..............................................^ {1b4c85df-cbdd-4bb6-b04e-613caece083c} is the CID of the jsdownloads nsITransfer. From Bug 1114624 Comment 0: (In reply to :Paolo Amadini from comment #0) > The override required in applications that still use nsIDownloadManager > would be implemented at startup using a technique similar to the one removed > by the patch. > The legacy CID and the contract ID are defined as NS_DOWNLOAD_CID and > NS_TRANSFER_CONTRACTID, and they are > "{b02be33b-d47c-4bd3-afd9-402a942426b0}" and "@mozilla.org/transfer;1" > respectively. s/1b4c85df-cbdd-4bb6-b04e-613caece083c/b02be33b-d47c-4bd3-afd9-402a942426b0/ r=me with this fixed. (In reply to Magnus Melin from comment #119) > Comment on attachment 8561092 [details] [diff] [review] > bug1130488_register_legacy_dlmanager.patch > > This, minus the dump. > I not exactly sure what was broken without this... basic attachment handling > seems ok with and without. 1. Go Tools->Saved Files 2. Notice that saved (i.e. downloaded) attachments don't show up in the legacy downloads window.
Attachment #8561092 -
Flags: review?(philip.chee) → review+
Assignee | ||
Comment 122•7 years ago
|
||
Thx! https://hg.mozilla.org/comm-central/rev/d63e44cf549c
Keywords: leave-open
Assignee | ||
Updated•7 years ago
|
Keywords: regression
Target Milestone: --- → mozilla38
![]() |
||
Comment 123•7 years ago
|
||
Didn't work....
Assignee | ||
Comment 124•7 years ago
|
||
What didn't work? The disabling hasn't been merged to mozilla-central yet.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•7 years ago
|
status-firefox36:
--- → unaffected
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•