1130569 - Follow-up: Improve list filtering efficiency

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Bug 1101741 added filtering on passwords, which is great! However, every time we filter, we go through and rebuild the list - can we be more efficient about this? Perhaps save a list of the items and toggle their visibility after running them through a filter function.

Comment 1

[:Margaret Leibovic]

I'm not convinced that toggling the visibility of list items is more efficient. In the case of a user filtering to a list of only one password, it's actually a lot less efficient to traverse a whole list of existing items than to just create one new one.

I think if anything, what we should do is avoid building a list of more than a certain number (20?) elements, and dynamically create more elements as the user scrolls.

But as with everything performance, I think we should wait until we see a need, and we should measure what's actually slow. Perhaps the best way to start here would be to try this out with a list of something like 1000 passwords and see what happens. If it isn't actually all that slow, then we could just WONTFIX this :)

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.