Closed Bug 1130576 Opened 5 years ago Closed 5 years ago

Rename JSPropertyOp -> JSGetterOp, JSStrictPropertyOp -> JSSetterOp

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file, 1 obsolete file)

Surprisingly, it turns out to make things nicer
/r/3473 - Bug 1130576 - Rename JSPropertyOp -> JSGetterOp and JSStrictPropertyOp -> JSSetterOp. r?efaust.

Pull down this commit:

hg pull review -r 31b29d17f2653211b47ad05928b021045034831f
Attachment #8560672 - Flags: review?(efaustbmo)
Comment on attachment 8560672 [details]
MozReview Request: bz://1130576/jorendorff

https://reviewboard.mozilla.org/r/3471/#review2839

::: js/src/jit/IonCaches.cpp
(Diff revision 1)
> -    // Despite the vehement claims of Shape.h that writable() is only
> +    // Despite the vehement claims of Shape.h that writable() is only relevant

I remember fixing the bug that left this comment behind... :)
Attachment #8560672 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/c0d21f2affd6
Assignee: nobody → jorendorff
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8560672 - Attachment is obsolete: true
Attachment #8619386 - Flags: review+
You need to log in before you can comment on or make changes to this bug.