1130630 - Move zoomed_view_stub from shared_ui_components to gecko_app

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We don't want this in web apps - just the browser (and maybe GeckoView).

Comment 1

[Dominique Vincent [:domivinc]]

Attachment: b-12022015 1-Bug_1130630____Move_zoomed_view_stub_from_shared_ui_components_to_gecko_app_r_mcomella.patch

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8563612 [details] [diff] [review]
b-12022015 1-Bug_1130630____Move_zoomed_view_stub_from_shared_ui_components_to_gecko_app_r_mcomella.patch

Review of attachment 8563612 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I don't think I got to mention this in the last bug - in order to get a patch checked in, you can add the "checkin-needed" keyword to the top of the page. However, all patches checked in with the keyword must have an associated green try run with them.

I believe you have try commit access so make the push! :) Since this feature is pref'ed off, you should add a commit at the bottom that enables the feature (don't bother attaching this to the bug).

Once the patch goes green, add the "checkin-needed" keyword and someone should be by to land your patch.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

By the way, I made sure you have the power to assign users to bugs (amongst other things) - bugzilla responsibly. :)

Thanks again for your help, Dominique!

Comment 5

[Dominique Vincent [:domivinc]]

https://tbpl.mozilla.org/?tree=Try&rev=8da20ba68c17

Comment 6

[Dominique Vincent [:domivinc]]

Michael, in the previous test, RC2 on Android 4.0 is red. I tried to run the same test without the code change (just the zoomed view flag = true) and I get the same red test (https://treeherder.mozilla.org/#/jobs?repo=try&revision=167bb4c1180d). 
The tests failed in testFindPage.js ; it's probably linked to this unresolved bug in the test suite: bug 1128287 .

Let me know how we should proceed in such situation? Wait for the resolution of bug 1128287 and re-test, or land the patch without a full green light?

Comment 7

[Dominique Vincent [:domivinc]]

https://tbpl.mozilla.org/?tree=Try&rev=e1b17eb84c31

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ec8bf5a601ef

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ec8bf5a601ef

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Dominique Vincent [:domivinc] from comment #6)
> Let me know how we should proceed in such situation? Wait for the resolution
> of bug 1128287 and re-test, or land the patch without a full green light?

I usually just run more tests - five or six is probably enough to know whether it's the intermittent or not, but use your judgment!

What you did here wfm!

Comment 11

[Bob Clary [:bc] (inactive)]

Let's back this out due to the web app failures.

Comment 12

[Aaron Train [:aaronmt]]

(In reply to Bob Clary [:bc:] from comment #11)
> Let's back this out due to the web app failures.

Bug 1134338 landed a fix on inbound