Closed Bug 1130630 Opened 7 years ago Closed 7 years ago

Move zoomed_view_stub from shared_ui_components to gecko_app

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: mcomella, Assigned: domivinc)

References

Details

Attachments

(1 file)

We don't want this in web apps - just the browser (and maybe GeckoView).
Comment on attachment 8563612 [details] [diff] [review]
b-12022015 1-Bug_1130630____Move_zoomed_view_stub_from_shared_ui_components_to_gecko_app_r_mcomella.patch

Review of attachment 8563612 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah!
Attachment #8563612 - Flags: review?(michael.l.comella) → review+
I don't think I got to mention this in the last bug - in order to get a patch checked in, you can add the "checkin-needed" keyword to the top of the page. However, all patches checked in with the keyword must have an associated green try run with them.

I believe you have try commit access so make the push! :) Since this feature is pref'ed off, you should add a commit at the bottom that enables the feature (don't bother attaching this to the bug).

Once the patch goes green, add the "checkin-needed" keyword and someone should be by to land your patch.
Assignee: nobody → domivinc
By the way, I made sure you have the power to assign users to bugs (amongst other things) - bugzilla responsibly. :)

Thanks again for your help, Dominique!
Michael, in the previous test, RC2 on Android 4.0 is red. I tried to run the same test without the code change (just the zoomed view flag = true) and I get the same red test (https://treeherder.mozilla.org/#/jobs?repo=try&revision=167bb4c1180d). 
The tests failed in testFindPage.js ; it's probably linked to this unresolved bug in the test suite: bug 1128287 .

Let me know how we should proceed in such situation? Wait for the resolution of bug 1128287 and re-test, or land the patch without a full green light?
Flags: needinfo?(michael.l.comella)
Keywords: checkin-needed
Flags: needinfo?(michael.l.comella) → needinfo?
Flags: needinfo?
https://hg.mozilla.org/mozilla-central/rev/ec8bf5a601ef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
(In reply to Dominique Vincent [:domivinc] from comment #6)
> Let me know how we should proceed in such situation? Wait for the resolution
> of bug 1128287 and re-test, or land the patch without a full green light?

I usually just run more tests - five or six is probably enough to know whether it's the intermittent or not, but use your judgment!

What you did here wfm!
Depends on: 1134338
Let's back this out due to the web app failures.
(In reply to Bob Clary [:bc:] from comment #11)
> Let's back this out due to the web app failures.

Bug 1134338 landed a fix on inbound
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.