1130632 - Add FirefoxOS version information to gaia build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Kevin Grandon :kgrandon]

For localization efforts we have a need to know the FirefoxOS version at build time. Currently this is stored in gecko, and written into a setting.

I would propose that we migrate this into a setting so we can consume this in the gaia build system. First we would include this in common-settings.json, then we would migrate gecko to read from this version.

Comment 1

[Kevin Grandon :kgrandon]

Ricky, George - Do you guys have any concerns about writing the FxOS version into settings and using it in the build? (If someone wants to take the bug that would also be welcome.) Thanks!

Comment 2

[Ricky Chien [:rickychien] (inactive)]

It's fine to us because it seems doesn't bring any problem to build system.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] RickyChien:bug-1130632 to mozilla-b2g:master

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8561175 [details] [review]
[PullReq] RickyChien:bug-1130632 to mozilla-b2g:master

Hi kevin, I'd like to use "moz.b2g.version" into common-settings.json but we can change it if you have another suggestion. 

BTW, Do we have to uplift the version to other branches (2.1/2.2)?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Ricky Chien [:rickychien] from comment #4)
> Comment on attachment 8561175 [details] [review]
> [PullReq] RickyChien:bug-1130632 to mozilla-b2g:master
> 
> BTW, Do we have to uplift the version to other branches (2.1/2.2)?

We need this in 2.2 for langpacks. No need for 2.1

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8561175 [details] [review]
[PullReq] RickyChien:bug-1130632 to mozilla-b2g:master

I think this makes sense to me. Gandalf - would this get you everything we need assuming we can parse it out?

Note - I left a comment on github. I think we can probably get away with just a '2.2' or '3.0' in the version string perhaps?

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> Comment on attachment 8561175 [details] [review]
> [PullReq] RickyChien:bug-1130632 to mozilla-b2g:master

> Note - I left a comment on github. I think we can probably get away with
> just a '2.2' or '3.0' in the version string perhaps?

Unless there's a reason for 3.0.0.0-prealpha, then I'd prefer 2.2, 3.0 etc.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Merged version 3.0 in master: 
https://github.com/mozilla-b2g/gaia/commit/a8fa0386eeb4b744d8cd154231c4bb8f05e4d95c

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] RickyChien:bug-1130632-v2.2 to mozilla-b2g:v2.2

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8561803 [details] [review]
[PullReq] RickyChien:bug-1130632-v2.2 to mozilla-b2g:v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a feature/regressing bug
[User impact] if declined: For localization efforts we have a need to know the FirefoxOS version at build time.
[Testing completed]: Manual check.
[Risk to taking this patch] (and alternatives if risky): It doesn't have any risk.
[String changes made]: none

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Landed in branch v2.2 at https://github.com/mozilla-b2g/gaia/commit/943be6fd146017dcd9d4c9d1027be1e43bad13eb

Comment 12

[Staś Małolepszy :stas]

Is there any documentation with steps to follow during branch day?  I'd like to minimize the risk of us forgetting to update this value on master right after branching happens.