New PRs are failing with the following: https://travis-ci.org/mozilla/firefox-ios/builds/49792944 ThirdParty/UIImageViewAligned was introduced in https://github.com/mozilla/firefox-ios/pull/130 (unlanded). <nalexander> I wonder if we're re-using a travis context, so we have a working tree in place that expects submodules? Stefan, did you set up Travis CI? Know what's happening here?
Yeah I setup Travis. I did not do much more than just put a .travis.yml in the project. I had hoped things would build but yes it fails on some git submodule. I don't want to spend much time on Travis now. But having that 3 line config in the project will at least tell us if PRs will build, etc. So that is a nice to have I think. Lets talk about git submodules on monday. I thought we avoided those .. for the same reason we put actual source code under ThirdParty. IMO that is still the best way to go to keep this project simple and 'check out and hit run in xcode' ...
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.