1130709 - build fails with musl libc: __BEGIN_DECLS not defined in media/webrtc/signaling/src/sdp/sipcc

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Felix Janda]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150207112030

Steps to reproduce:

Try to build on a musl libc based system (http://musl-libc.org)


Actual results:

Compile failure in media/webrtc/signaling/src/sdp/sipcc/cpr_string.h because of undefined __BEGIN_DECLS. The files media/webrtc/signaling/src/sdp/sipcc/cpr_*_types.h defines __BEGIN_DECLS, however don't seem to be included in media/webrtc/signaling/src/sdp/sipcc/cpr_types.h because SIP_OS_* is not defined.

Comment 1

[Felix Janda]

Attachment: Proposed patch

The patch expands __BEGIN_DECLS and __END_DECLS in the 3 places where it is used and removes their definitions from cpr_*_types.h.

If the firefox build system does not export SIP_OS_*, the files cpr_*_types.h might actually be unused.

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8560854 [details] [diff] [review]
Proposed patch

Review of attachment 8560854 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sdp/sipcc/cpr_strings.h
@@ +7,3 @@
>  
>  #include "cpr_types.h"
>  

Let's keep the extern "C" stuff here. Otherwise ok.

Do you have try access? If not, I can do a try push once you have a new patch.

Comment 3

[Felix Janda]

Thanks for reviewing.

The rationale for leaving out the extern "C" in crp_strings.h is that this header contains only #defines (and no function declarations,...), which are not subject to name mangling.

I don't have try access. Thanks for offering to do a try push for me!

Comment 4

[Felix Janda]

Attachment: Requested more careful patch

Comment 5

[Byron Campen [:bwc]]

(In reply to Felix Janda from comment #3)
> Thanks for reviewing.
> 
> The rationale for leaving out the extern "C" in crp_strings.h is that this
> header contains only #defines (and no function declarations,...), which are
> not subject to name mangling.
> 
> I don't have try access. Thanks for offering to do a try push for me!

   Ahh, I was looking at cpr_string.h and not cpr_strings.h in dxr. My mistake.

Comment 6

[Byron Campen [:bwc]]

Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2902c26d01c5

Comment 7

[Byron Campen [:bwc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e7a3784e747

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e7a3784e747

Comment 9

[David Lawrence [:dkl]]

Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl