1130756 - Assertion failure: frame.isDebuggee(), at vm/Debugger.cpp:1984

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Testcase

Attached testcase asserts with --baseline-eager at inbound revision 9a3a666c17d7.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Set BaselineFrame's isDebuggee flag before any operation that can re-enter the VM.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8560927 [details] [diff] [review]
Set BaselineFrame's isDebuggee flag before any operation that can re-enter the VM.

Review of attachment 8560927 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this so quickly.

::: js/src/jit/BaselineCompiler.cpp
@@ +574,5 @@
> +void
> +BaselineCompiler::emitIsDebuggeeCheck()
> +{
> +    if (compileDebugInstrumentation_) {
> +        masm.setupUnalignedABICall(1, R0.scratchReg());

We should push/pop BaselineFrameReg before/after the call, I think it's non-volatile on ARM (r11).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba9da2364774