1130787 - prtime.h does not compile with MSVC's /Za (ISO C/C++ conformance) option

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

When compiling a C++ program that includes prtime.h with MSVC's /Za option, the build fails with these errors/warnings:

Nonstandard extension used: formal parameter 'tm' was previously defined as a type.

The /Za option is described here: https://msdn.microsoft.com/en-us/library/0k0w269d.aspx

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Enable prtime.h to be compiled with MSVC's /Za option

Note that this patch is not enough to allow NSPR itself to be compiled with /Za. It simply enables programs that include prtime.h (perhaps indirectly through NSS's header files) to compile with /Za.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8560931 [details] [diff] [review]
Enable prtime.h to be compiled with MSVC's /Za option

Review of attachment 8560931 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the review delay.

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/projects/nspr/rev/a1a22dd6a680

Comment 4

[Wan-Teh Chang]

Attachment: Fix indentation in prtime.h and rename the function parameter in prtime.c.

Comment 5

[Wan-Teh Chang]

Comment on attachment 8596208 [details] [diff] [review]
Fix indentation in prtime.h and rename the function parameter in prtime.c.

Patch checked in: https://hg.mozilla.org/projects/nspr/rev/5e45180adf13