Refactor nsTablePainter a little

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8560959 [details] [diff] [review]
patch

I was bored and started to look into bug 929484. I thought I'd start by cleaning up the code a little, while I was reading through it.

There's a summary about what the patch does in its commit message.
Attachment #8560959 - Flags: review?(roc)
Be warned that we are going to stomp on each others' toes here, as I'm also making changes to nsTablePainter in bug 1128769.
(Assignee)

Comment 2

4 years ago
Thanks for the heads up. Let's see what gets reviewed first :-)
I'll create the updated second patch on top of the first patch in either case, it's the same work.
Comment on attachment 8560959 [details] [diff] [review]
patch

Review of attachment 8560959 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tables/nsTablePainter.h
@@ +123,5 @@
>       * pass through and paint underlying layers only
>       * See Public versions for function descriptions
>       */
> +    void PaintRowGroup(nsTableRowGroupFrame* aFrame,
> +                       TableBackgroundData   aRowGroupBGData,

Add a comment explaining why this isn't a reference

@@ +128,5 @@
> +                       bool                  aPassThrough);
> +
> +    void PaintRow(nsTableRowFrame* aFrame,
> +                  const TableBackgroundData& aRowGroupBGData,
> +                  TableBackgroundData aRowBGData,

Ditto
Attachment #8560959 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/7d1f5d6d0835
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.