1130817 - Refactor nsTablePainter a little

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Attachment: patch

I was bored and started to look into bug 929484. I thought I'd start by cleaning up the code a little, while I was reading through it.

There's a summary about what the patch does in its commit message.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Be warned that we are going to stomp on each others' toes here, as I'm also making changes to nsTablePainter in bug 1128769.

Comment 2

[Markus Stange [:mstange]]

Thanks for the heads up. Let's see what gets reviewed first :-)
I'll create the updated second patch on top of the first patch in either case, it's the same work.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8560959 [details] [diff] [review]
patch

Review of attachment 8560959 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tables/nsTablePainter.h
@@ +123,5 @@
>       * pass through and paint underlying layers only
>       * See Public versions for function descriptions
>       */
> +    void PaintRowGroup(nsTableRowGroupFrame* aFrame,
> +                       TableBackgroundData   aRowGroupBGData,

Add a comment explaining why this isn't a reference

@@ +128,5 @@
> +                       bool                  aPassThrough);
> +
> +    void PaintRow(nsTableRowFrame* aFrame,
> +                  const TableBackgroundData& aRowGroupBGData,
> +                  TableBackgroundData aRowBGData,

Ditto

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1f5d6d0835

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d1f5d6d0835