Closed Bug 1130827 Opened 5 years ago Closed 5 years ago

Odin: use SIMD load/store for the fbird test now that they are implemented.

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: dougc, Assigned: dougc)

Details

Attachments

(1 file, 1 obsolete file)

The simd-fbird test is using repeated float32 loads and stores to emulate float32x4 loads and stores. Now that these SIMD load and store have been implemented would it be appropriate to use them. It might increase the test coverage a little.
Comment on attachment 8560977 [details] [diff] [review]
Use SIMD load/store for the fbird test now that they are implemented

Review of attachment 8560977 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Can you also keep in sync [0] and [1]? (in the latter, updating both the -native and -polyfill versions)
Ideally, this patch should land once the two github repos have been synchronized.

[0] https://github.com/PeterJensen/fbird
[1] https://github.com/h4writer/arewefastyet/tree/master/benchmarks/asmjs-ubench
Attachment #8560977 - Flags: review?(benj) → review+
Update. Looks like there has been a semantics change. Carry forward r+.
Attachment #8560977 - Attachment is obsolete: true
Attachment #8565881 - Flags: review+
Requesting checkin. Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=039dccc1ca63
Assignee: nobody → dtc-moz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f47810257e98
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.