1130827 - Odin: use SIMD load/store for the fbird test now that they are implemented.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Douglas Crosher [:dougc]]

The simd-fbird test is using repeated float32 loads and stores to emulate float32x4 loads and stores. Now that these SIMD load and store have been implemented would it be appropriate to use them. It might increase the test coverage a little.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: Use SIMD load/store for the fbird test now that they are implemented

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8560977 [details] [diff] [review]
Use SIMD load/store for the fbird test now that they are implemented

Review of attachment 8560977 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Can you also keep in sync [0] and [1]? (in the latter, updating both the -native and -polyfill versions)
Ideally, this patch should land once the two github repos have been synchronized.

[0] https://github.com/PeterJensen/fbird
[1] https://github.com/h4writer/arewefastyet/tree/master/benchmarks/asmjs-ubench

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

I've done it for you :)
https://github.com/h4writer/arewefastyet/pull/46
https://github.com/PeterJensen/fbird/pull/1

Comment 4

[Douglas Crosher [:dougc]]

Attachment: Use SIMD load/store for the fbird test now that they are implemented.

Update. Looks like there has been a semantics change. Carry forward r+.

Comment 5

[Douglas Crosher [:dougc]]

Requesting checkin. Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=039dccc1ca63

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f47810257e98

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f47810257e98