Last Comment Bug 1130841 - Fix the TodayLabel color for systemcolors
: Fix the TodayLabel color for systemcolors
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Calendar Views (show other bugs)
: unspecified
: All All
-- normal (vote)
: 4.0.0.1
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-08 03:59 PST by Richard Marti (:Paenglab)
Modified: 2015-02-08 06:06 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
MonthTodayLabelFix.patch (4.18 KB, patch)
2015-02-08 04:04 PST, Richard Marti (:Paenglab)
philipp: review+
Details | Diff | Splinter Review

Description User image Richard Marti (:Paenglab) 2015-02-08 03:59:52 PST
From bug 1121373 comment 4:
> I've also noticed that the background color of the label for "today" when
> systemcolors are active is different than before the introduction of the css
> variables (now is Highlight, before it was absent).
> Looks like it needs a different variable for the background in the rule
> .calendar-month-day-box-date-label[relation="today"][selected="true"]
> in order to have the possibility to differentiate the background in the
> systemcolors case.
Comment 1 User image Richard Marti (:Paenglab) 2015-02-08 04:04:23 PST
Created attachment 8560993 [details] [diff] [review]
MonthTodayLabelFix.patch

The foreground- and background colors are only inverted in systemcolors mode. Thus needs to double the variables to not mess in normal color mode.
Comment 2 User image Philipp Kewisch [:Fallen] 2015-02-08 06:06:43 PST
Pushed to comm-central changeset 7b97c6188612

Note You need to log in before you can comment on or make changes to this bug.