1130842 - Add ipc error annotation when content processes abort in ProcessingError

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/annotate/34a66aaaca81/dom/ipc/ContentChild.cpp#l1808

We did this for the parent, we should add this for the child too using the same meta id of 'ipc_channel_error'.

Comment 1

[Jim Mathies [:jimm]]

Attachment: wip

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

there was no need to change the protocol.

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch

sorry for the bugspam, this time without the debug test code.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8561000 [details] [diff] [review]
patch

Review of attachment 8561000 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/PCrashReporter.ipdl
@@ +23,3 @@
>    manager PContent or PPluginModule or PGMP;
>  parent:
> +  sync AnnotateCrashReport(nsCString key, nsCString data);

I don't think it's a good idea to make this sync. We call this function pretty often. Every time we load a page, for example. I'd hate to introduce extra sync calls in all these places.

If the annotation isn't arriving in time, it's probably a bug in the IPC code. I'd rather address it there. Alternatively, we could send a sync message in ProcessingError, after AnnotateCrashReport, just to flush everything out.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8561056 [details] [diff] [review]
patch

Review of attachment 8561056 [details] [diff] [review]:
-----------------------------------------------------------------

You're too fast for me! :-)

Comment 7

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab5af4ff18cc

thanks!

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/603b98af7463

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/603b98af7463