1130883 - History heading shows when no results

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Kevin Grandon :kgrandon]

I'd like to take this one if no one is working on it.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1130883_history_heading > mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8564522 [details] [review]
[gaia] KevinGrandon:bug_1130883_history_heading > mozilla-b2g:master

Hey Dale - what do you think of this? I think that using the observer is kind of nice because it decouples it from places.js and we don't have to add any logic to places.js. I suppose if we don't want to use the mutation observer, then we could use an event or something from places.js.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1130883_history_heading_without_test > mozilla-b2g:master

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8564522 [details] [review]
[gaia] KevinGrandon:bug_1130883_history_heading > mozilla-b2g:master

Having trouble with the history test, as I think there's a race condition somewhere possibly. I think I'd like to get the functionality landed and follow-up with the test.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8564971 [details] [review]
[gaia] KevinGrandon:bug_1130883_history_heading_without_test > mozilla-b2g:master

Dale - can you take a look when you have time? Thanks!

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8564971 [details] [review]
[gaia] KevinGrandon:bug_1130883_history_heading_without_test > mozilla-b2g:master

Yeh would like to see a test along with this, but the code looks nice

Comment 8

[Kevin Grandon :kgrandon]

Thanks - I would also like to work on a test for this and have one ready, but there's just some race with history =( Will try to get this added afterwards.

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1455349736277a498fa2fde57fbaddca63aab3b2

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8564971 [details] [review]
[gaia] KevinGrandon:bug_1130883_history_heading_without_test > mozilla-b2g:master

Would like to uplift this polish for the search experience.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Slight UX papercut.
[Testing completed]: Manual testing (will follow-up with integration tests, but running into problems landing them right now)
[Risk to taking this patch] (and alternatives if risky): Low risk, self-contained polish.
[String changes made]: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2f5082e2950f451e8e06017a9cbff4cb685ddd07

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame v2.2&2.5&master and Aries KK v2.5&master.

STR：
1.Open the Browser app for the first time, or clear all history from Settings->Browsing Privacy.

Actual results: "History" header doesn't display to user when no any results in Browser app.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


----------------------------------------------------------------------------------
Device: Flame master_512mb eng (Pass)
Build ID               20151210150222
Gaia Revision          7e962276913bd4da7ce5fa7540767107ce322c78
Gaia Date              2015-12-09 21:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/412e4d7ce98ca4dbc37de133d0f26d7e1a59946f
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151210.183953
Firmware Date          Thu Dec 10 18:40:06 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master eng (Pass)
Build ID               20151210120926
Gaia Revision          7e962276913bd4da7ce5fa7540767107ce322c78
Gaia Date              2015-12-09 21:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/412e4d7ce98ca4dbc37de133d0f26d7e1a59946f
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151210.112747
Firmware Date          Thu Dec 10 11:27:55 UTC 2015
Bootloader             s1

Device: Flame 2.5_512mb user (Pass)
Build ID               20151211000407
Gaia Revision          2eb55a6193b711b4acb5944be3ba8fea138506c8
Gaia Date              2015-12-10 21:18:06
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d0aa054f0eeae855ff0b4d7ef6c984ab96fd1944
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151210.231805
Firmware Date          Thu Dec 10 23:18:14 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 dogfood (Pass)
Build ID               20151211001044
Gaia Revision          2eb55a6193b711b4acb5944be3ba8fea138506c8
Gaia Date              2015-12-10 21:18:06
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d0aa054f0eeae855ff0b4d7ef6c984ab96fd1944
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151210.232018
Firmware Date          Thu Dec 10 23:20:26 UTC 2015
Bootloader             s1

Device: Flame 2.2_512mb eng (Pass) 
Build ID               20151210032501
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4381c4b69b9c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151210.072346
Firmware Date          Thu Dec 10 07:23:57 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.png