Closed
Bug 1130902
Opened 9 years ago
Closed 9 years ago
Notifications are not sent when modifying events
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
940 bytes,
patch
|
redDragon
:
review+
|
Details | Diff | Splinter Review |
The sendNotifications parameter is not added.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8561130 -
Flags: review?(mohit.kanwal)
Comment 2•9 years ago
|
||
Comment on attachment 8561130 [details] [diff] [review] Fix - v1 Review of attachment 8561130 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Tested and works. Should we use something like cal.sendNotifications(...) instead of directly accessing the preference?
Attachment #8561130 -
Flags: review?(mohit.kanwal) → review+
Assignee | ||
Comment 3•9 years ago
|
||
The pref is gdata specific and all that needs to be done is adding the parameter to the request, so I'd rather keep it without a helper. Thanks for the hint though :)
Keywords: checkin-needed
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•