Last Comment Bug 1130902 - Notifications are not sent when modifying events
: Notifications are not sent when modifying events
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Provider: GData (show other bugs)
: Trunk
: All All
-- normal (vote)
: 4.0.0.1
Assigned To: Philipp Kewisch [:Fallen]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-08 16:05 PST by Philipp Kewisch [:Fallen]
Modified: 2015-02-13 15:00 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix - v1 (940 bytes, patch)
2015-02-08 16:06 PST, Philipp Kewisch [:Fallen]
mohit.kanwal: review+
Details | Diff | Splinter Review

Description User image Philipp Kewisch [:Fallen] 2015-02-08 16:05:19 PST
The sendNotifications parameter is not added.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-02-08 16:06:26 PST
Created attachment 8561130 [details] [diff] [review]
Fix - v1
Comment 2 User image Mohit Kanwal [:redDragon] 2015-02-09 00:24:35 PST
Comment on attachment 8561130 [details] [diff] [review]
Fix - v1

Review of attachment 8561130 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Tested and works. Should we use something like cal.sendNotifications(...) instead of directly accessing the preference?
Comment 3 User image Philipp Kewisch [:Fallen] 2015-02-09 01:01:50 PST
The pref is gdata specific and all that needs to be done is adding the parameter to the request, so I'd rather keep it without a helper. Thanks for the hint though :)

Note You need to log in before you can comment on or make changes to this bug.