Closed
Bug 1130903
Opened 10 years ago
Closed 10 years ago
Avoid unboxValue when storing unboxed properties
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
1.60 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Calling unboxValue with ScratchDoubleReg isn't valid on x86.
Attachment #8561131 -
Flags: review?(jdemooij)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8561131 [details] [diff] [review]
patch
Review of attachment 8561131 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/MacroAssembler.cpp
@@ +775,5 @@
> +#ifdef JS_NUNBOX32
> + convertInt32ToDouble(reg.payloadReg(), ScratchDoubleReg);
> +#else
> + convertInt32ToDouble(reg.valueReg(), ScratchDoubleReg);
> +#endif
These 5 lines can be int32ValueToDouble(reg, ScratchDoubleReg);
Attachment #8561131 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•