1130989 - Collections details page is different in Mocks compered to MP-dev

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Load details page for any collection from MP-dev homepage https://marketplace-dev.allizom.org/feed/collection/hippo?src=collection-element

Expected results:
There are no display or layout issues.

Actual results:
There is a white line after the last row of apps.

Notes/Issues:
Verified on MP-dev on FF38 (Win 7). Issue is also reproduce on FF OS 1.4 .
Screenshot for this issue http://screencast.com/t/ml6QIILkb

Comment 1

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/pull/1012

Comment 2

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified as fixed on MP-dev FF38(Win 7, Android 4.2.1).
Postfix screenshot http://screencast.com/t/vre4D1qZJ

The issue was not fixed on FF OS 1.4 (Inari), is this intended? (the mp-dev app is up to date)

Comment 3

[Davor Spasovski [:spasovski]]

It was intentional to not affect mobile but I agree that it looks better with the last line missing there too. Fixed:

https://github.com/mozilla/fireplace/commit/260456c

Comment 4

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Davor Spasovski [:spasovski] from comment #3)
> It was intentional to not affect mobile but I agree that it looks better
> with the last line missing there too. Fixed:
> 
> https://github.com/mozilla/fireplace/commit/260456c

Thanks!

Verified as fixed on MP-dev on FF OS 1.4 (Inari)
Closing bug.