1130998 - Whines are sent with an incorrect email address

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Mark Banner (:standard8)]

I have a weekly whine set up, and I've noticed that the email address it is "from" is wrong. Not sure if this is a bmo specific thing, so filing here first.

When I get the whine, it has the from header as:

From: "Bugzilla@Mozilla" <"Bugzilla@Mozilla" <[e-mail]>>

It should be:

From: "Bugzilla@Mozilla" <[e-mail]>

Comment 1

[:glob ✱]

odd; i cannot reproduce this locally.  the email we generate out of bugzilla should contain a correct from header.  there may be shenanigans on the server which runs the cron jobs; investigate further i shall.

Comment 2

[:glob ✱]

looking at my emails, this broke between [12 Jan 2015 12:00:09 -0800] and [13 Jan 2015 12:00:10 -0800].

we didn't make any code or configuration changes within that period.
there was a code push at [13 Jan 2015 07:27:39 -0800] but clearly that was some time after this started happening.

i'm still poking around, but at this stage it looks like something changed infrastructure-wise.

Comment 3

[:glob ✱]

the problem is the version of whine.pl in /data/bugzilla/www/bugzilla.mozilla.org on the admin node doesn't match what's in source control; it's missing code that was changed 9 months ago!

the following files are different between that directory and git/master (ignoring unpushed changes):
  modified:   email_in.pl
  modified:   importxml.pl
  modified:   whine.pl

only the differences in whine.pl will cause issues.


fubar: what happened on jan 12 to cause this, and how do we fix it?

Comment 4

[Kendall Libby [:fubar] (he/him)]

Everything in /data/bugzilla/www is rsync'ed over from /data/bugzilla/src, which is checked out from git. What are you using to compare? (not saying you're wrong, just want to see where things broke)

git status doesn't show those files as different, but it does say "Your branch is ahead of 'origin/master' by 55 commits." which seems ... odd. 

AFAIK, nothing changed on the 12th, but I see that errors, .gitignore, and .perltidyrc were changed on Jan 13 07:27 (-0800, I think), but that coincides with the first push after converting from bzr to git. 

also, the push script does a `git reset --hard origin/master` so even if the file is modified locally it'll get wiped out. rsync also shouldn't let things get out of sync in /www/...  

lastly, looking at the diff of whine.pl, the code change looks *really* famililar, but I believe that's from the staging (or dev) cutover. I did a diff -r on the bzr and git trees to make sure content matched and I seem to remember one of dev/staging having a few files that were off. That wasn't the case on prod, though.

Comment 5

[Kendall Libby [:fubar] (he/him)]

looking at the bzr backup tarball, it had the correct whine.pl. could this be related to the dev code merge snafu at the all hands ? 

ping me tomorrow morning my time and we can chat and get this cleaned up (assuming you don't do a push and it gets fixed then)

Comment 6

[:glob ✱]

(In reply to Kendall Libby [:fubar] from comment #4)
> Everything in /data/bugzilla/www is rsync'ed over from /data/bugzilla/src,
> which is checked out from git. What are you using to compare? (not saying
> you're wrong, just want to see where things broke)

i initially found this as part of trying to trace down the issue by looking through the files.  when i realised that one file was wrong, i grabbed a copy of the whole directory, copied in the .git directory from my dev box and ran |git status|.

> looking at the bzr backup tarball, it had the correct whine.pl. could this
> be related to the dev code merge snafu at the all hands ? 

no; that was upstream bugzilla, not bmo.

> ping me tomorrow morning my time and we can chat and get this cleaned up
> (assuming you don't do a push and it gets fixed then)

roger.

Comment 7

[:glob ✱]

*looks sheepish*

so, it appears the files are actually wrong in the production branch only; this appears to be a partial master->production merge.  while investigating i was checking against the master branch, not production.

i'll fix up the branch, sorry about the false alarm there fubar!

Comment 8

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   75be04e..28acb3b  production -> production