Closed
Bug 1131056
Opened 11 years ago
Closed 10 years ago
Add tests for webactivities code in fireplace
Categories
(Marketplace Graveyard :: Code Quality, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mat, Unassigned)
References
Details
(Whiteboard: [marketplace-transition])
Fireplace's webactivities.js is not covered by unit tests.
With the current testing architecture it can be tricky to do - I tried to do it as part of bug 1122272 but it turned out to be slightly more complicated than I had anticipated so I am opening this bug instead.
Random notes:
- We should expose expose handleActivity() method and we should test it independently
- Testing mozSetMessageHandler and message passing should be done too
- We need to figure out a way to test this without actually navigating away. Sadly, the modules that webactivities.js requires all use `z` module in various ways, and with our current testing architecture, it's difficult to mock just z.page.trigger() without affecting those modules.
- We could also add integration tests, triggering various activities/messages and looking where we end up navigating, without mocking anything.
Updated•11 years ago
|
Priority: -- → P3
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in
before you can comment on or make changes to this bug.
Description
•