Closed
Bug 1131092
Opened 9 years ago
Closed 9 years ago
Fix mFileStatus ordering in CacheEntry::Load
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
Attachments
(1 file, 1 obsolete file)
1.13 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
Based on log from bug 1120631. Apparently there is a code path that allows access to CacheEntry.mFile (as mFileStatus == OK) sooner than CacheFile::Init() is called on it. This is there since ever.
Attachment #8561418 -
Flags: review?(michal.novotny)
Updated•9 years ago
|
Attachment #8561418 -
Flags: review?(michal.novotny) → review+
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb4fb9d0b230
Keywords: checkin-needed
Comment 2•9 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1079789#c28
Keywords: checkin-needed
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c34ac09f8042
Attachment #8561418 -
Attachment is obsolete: true
Attachment #8564178 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a61c3921843
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a61c3921843
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•