Closed
Bug 1131111
Opened 9 years ago
Closed 9 years ago
PN Changes (Snippets/SMS Campaign, default Search provider, and SSL Error reporting)
Categories
(Privacy Graveyard :: Privacy Policies, task, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: gpiper, Assigned: CocoMo)
References
()
Details
(Whiteboard: [kb=1658731] In GitHub for completion)
Attachments
(1 file)
Three revisions to the Fx Desktop PN: (1) Snippets/SMS Campaign (2) Default Search provider, and (3) SSL Error reporting https://github.com/GeoffPiperMZ/legal-docs/commit/f7a5ad3ac4299456d742981b96b16b6cc01bb20b
Reporter | ||
Updated•9 years ago
|
Assignee: jmenon → gpiper
Whiteboard: In GitHub for completion
Reporter | ||
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•9 years ago
|
||
Geoff, please assign the bug to me once content update is complete. Thank you!
Reporter | ||
Comment 2•9 years ago
|
||
Jen, Mike, Kohei...what's the status of this change to the PN? The Snippets campaign goes live February 12 btw. Can we get this live for that?
Severity: major → critical
Priority: P2 → P1
Comment 3•9 years ago
|
||
Sent a pull request. The changes should be live tomorrow.
Assignee: gpiper → kohei.yoshino
Status: NEW → ASSIGNED
Updated•9 years ago
|
Whiteboard: In GitHub for completion → [kb=1658731] In GitHub for completion
Comment 4•9 years ago
|
||
Geoff: can you please send a pull request to mozilla/legal-docs as before, so that we can merge the changes into mozilla/bedrock (www.mozilla.org). Thanks!
Flags: needinfo?(gpiper)
Reporter | ||
Comment 5•9 years ago
|
||
I sent a pull request. Not sure if this accomplished what you need now. This is urgent. Sorry, but tings seemed very different this time. Not a Git Hub expert ;)
Reporter | ||
Comment 6•9 years ago
|
||
I started over, made the changes again, and created a new pull request: https://github.com/mozilla/legal-docs/pull/288
Flags: needinfo?(gpiper)
Comment 7•9 years ago
|
||
I r+'d Geoff's PR. :kohei, can we merge/push today?
Flags: needinfo?(kohei.yoshino)
Comment 8•9 years ago
|
||
Looks like people are busy migrating to Python 2.7 today. Once everything goes well, I'll ping someone on IRC.
Flags: needinfo?(kohei.yoshino)
Comment 9•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/f9849c7955026cc011fbc8534ee91207f904bfd0 Fix Bug 1131111 - PN Changes (Snippets/SMS Campaign, default Search provider, and SSL Error reporting) https://github.com/mozilla/bedrock/commit/e77deed3611f5ff8a6f50656b5baebdbc8fed7c9 Merge pull request #2720 from kyoshino/bug-1131111-privacy-notice-updates Fix Bug 1131111 - PN Changes (Snippets/SMS Campaign, default Search provider, and SSL Error reporting)
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•9 years ago
|
||
Great! Assigning to Peiying now for localization
Assignee: kohei.yoshino → pmo
Reporter | ||
Comment 12•9 years ago
|
||
Kohei, it came to my attention that there is a hard return missing in the newly added Default Search aspect to these changes we made to the privacy notice. "Default Search" needs to be on its own line as the bullet (just as "Tiles" is above it), with a hard return so the paragraph starts on its own new line. Can we arrange for that to be fixed asap? ~GP
Comment 13•9 years ago
|
||
Hi Geoff- Do you need this done today? We usually don't push to product on Friday afternoons. Could this wait until Monday? Thanks, Jen
Reporter | ||
Comment 14•9 years ago
|
||
Monday is fine ;)
Comment 15•9 years ago
|
||
Thanks!
Assignee | ||
Comment 16•9 years ago
|
||
We just completed translation for this update. Is it a change that impacts other languages or just English?
Reporter | ||
Comment 17•9 years ago
|
||
Its actually a formatting correcting, no changes to any words at all.
You need to log in
before you can comment on or make changes to this bug.
Description
•