Esc should close the graph tooltips

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: mishravikas)

Tracking

Details

Attachments

(1 attachment)

It has been requested that the key 'Esc' should close the graph tooltips in the perfherder UI. Probably best to use the mousetrap library for this:

http://craig.is/killing/mice

I thought this was already in treeherder but it looks like the patch that was adding this originally is backed out for now. See bug 1121631. Still, this seems like the best way forward-- please add it to the vendor directory (see the PR/patch for that bug for an example) and make perf.js use it. :)
(Assignee)

Comment 1

3 years ago
Here's the pr: https://github.com/mozilla/treeherder-ui/pull/363
(Assignee)

Comment 2

3 years ago
Created attachment 8563396 [details] [review]
https://github.com/mozilla/treeherder-ui/pull/363
Attachment #8563396 - Flags: review?(wlachance)
Comment on attachment 8563396 [details] [review]
https://github.com/mozilla/treeherder-ui/pull/363

Looks good except for the minor issue :jfrench noticed. Could you fix that up and update the PR?
Attachment #8563396 - Flags: review?(wlachance) → review+

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/8e15cb8940fd27708be5928b6a63b470f9bf1696
Bug 1131183 - Esc should close the graph tooltips
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/36a87e68f304ccce0e10476d7a32caa3ea32c7a8
Bug 1131183 - Esc should close the graph tooltips
You need to log in before you can comment on or make changes to this bug.