Closed
Bug 1131183
Opened 9 years ago
Closed 9 years ago
Esc should close the graph tooltips
Categories
(Tree Management :: Perfherder, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: mishravikas)
Details
Attachments
(1 file)
It has been requested that the key 'Esc' should close the graph tooltips in the perfherder UI. Probably best to use the mousetrap library for this: http://craig.is/killing/mice I thought this was already in treeherder but it looks like the patch that was adding this originally is backed out for now. See bug 1121631. Still, this seems like the best way forward-- please add it to the vendor directory (see the PR/patch for that bug for an example) and make perf.js use it. :)
|
Assignee | |
Comment 1•9 years ago
|
||
Here's the pr: https://github.com/mozilla/treeherder-ui/pull/363
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8563396 -
Flags: review?(wlachance)
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8563396 [details] [review] https://github.com/mozilla/treeherder-ui/pull/363 Looks good except for the minor issue :jfrench noticed. Could you fix that up and update the PR?
Attachment #8563396 -
Flags: review?(wlachance) → review+
|
||
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/8e15cb8940fd27708be5928b6a63b470f9bf1696 Bug 1131183 - Esc should close the graph tooltips
|
|
Reporter | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/36a87e68f304ccce0e10476d7a32caa3ea32c7a8 Bug 1131183 - Esc should close the graph tooltips
You need to log in
before you can comment on or make changes to this bug.
Description
•