1131248 - Swap out yellow palette color for another one

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[David Durst [:ddurst]]

The existing yellow palette color (#FAD73B) fails WCAG contrast tests.

For now, we need swap it out for something else in fireplace (whether it needs to be removed from transonic itself is probably something to be determined with Phil, as few shades are going to not fail WCAG with white text atop them).

Comment 1

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/commit/7d5e7f05baa23dce3d1a39f36568498eef722438

Comment 2

[Madalin Cotetiu]

I have created a featured app using the yellow color. In the homepage it was swapped to blue. Is this the intended behavior?
Please view this screenshot: http://screencast.com/t/9GEhyv5y

Comment 3

[David Durst [:ddurst]]

For now, yes.

Comment 4

[Philip [:pwalm]]

Death to yellow in all forms, no hue passes WCAG. Kill it.

Comment 5

[Madalin Cotetiu]

I observer this issue still reproducing in production and stage for Editorial brands. 
stage: http://screencast.com/t/Vcb81QrcMWBI
prod:  http://screencast.com/t/sdIluQTUZfhQ

Comment 6

[David Durst [:ddurst]]

No hue passes WCAG with white text on top of it, but given the color identifications we use in HTML, couldn't we just set the text to black via CSS when the color is "topaz"?

I agree that yellow breaks it up, and ... we can conceivably make it readable.

We could also determine it by javascript, but CSS seems easier.

Comment 7

[Kevin Ngo [:ngoke]]

I'm halfway done bumping it, but I'm going to wait further to see if black n yellow is doable.

https://github.com/mozilla/marketplace-constants/pull/24
https://github.com/mozilla/transonic/commit/eaf188dd08008e7bd4b67c0e3210d2f978d7ee3b

Comment 8

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/1a5607f2ff4e3705811245c43f6458dfad97011c
https://github.com/mozilla/fireplace/commit/69560690edccfd97b3321caace005a985d988010

verdict stands: kill all yellow

Comment 9

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/commit/04b722c059cbbf22193451dd1fe3bb7c1279be0c

Comment 10

[Kevin Ngo [:ngoke]]

Note that yellow is coming back in https://bugzilla.mozilla.org/show_bug.cgi?id=1132267 in a different golden form.

Comment 11

[Madalin Cotetiu]

So now the yellow should be back?
The following behavior can be observed on mp-dev:
A featured app created using the yellow color is displayed blue in the home tab: http://screencast.com/t/kD7wPBtlBv7A
A collection created using the yellow color is displayed yellow in the home tab: http://screencast.com/t/ODQbbq7wnx
Also in the feed preview in the Publish page the old collection are displayed with the old yellow hue: http://screencast.com/t/ccn74IlC9No1

So I am a bit confused. For which feed elements should the yellow be swapped, in which case the the "new" yellow should be displayed. Kevin can you please explain?

Comment 12

[Kevin Ngo [:ngoke]]

Thanks for reporting! I fixed the featured app being blue: https://github.com/mozilla/fireplace/commit/25edd56b0d5a77260d855631e0c7e8f3013be49c

The preview being outdated can be a separate bug, to refresh the Curation Tools feed preview, but that is low priority as editorial is more concerned with content than display in that case.

Comment 13

[Madalin Cotetiu]

Verified as fixed in FF38(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/R7IERqCjh
Closing bug.