1131309 - Add share buttons to 'Check your plugins' page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[William Reynolds [:williamr]]

To increase downloads of Firefox through referrals, we want to add sharing buttons (Twitter, Facebook, Google+) on this page:

https://www.mozilla.org/plugincheck/

Let's use the new-style <Share link that appears on the Firefox Hello page:
https://www.mozilla.org/firefox/hello/

We can use the same placement in the top right area to be consistent across our pages.

Comment 1

[William Reynolds [:williamr]]

Liz, can you please create the three Google Analytics links for this page (Twitter, Facebook, Google+) similar to the ones on the Firefox Hello page? A pre-written tweet message would be super too.

Comment 2

[Jennifer Bertsch [:jbertsch]]

Hi Schalk-

Who else should be invited to comment/approve this request?  Other than you?

Thanks,
Jen

Comment 3

[Schalk Neethling [:espressive]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #2)
> Hi Schalk-
> 
> Who else should be invited to comment/approve this request?  Other than you?
> 
> Thanks,
> Jen

If you are ok with it, I am ok with it ;) There is definitely a lot of traffic in this page so make sense to leverage that.

Comment 4

[Jennifer Bertsch [:jbertsch]]

(In reply to Schalk Neethling [:espressive] from comment #3)
> (In reply to Jennifer Bertsch [:jbertsch] from comment #2)
> > Hi Schalk-
> > 
> > Who else should be invited to comment/approve this request?  Other than you?
> > 
> > Thanks,
> > Jen
> 
> If you are ok with it, I am ok with it ;) There is definitely a lot of
> traffic in this page so make sense to leverage that.

Thanks Schalk!

WilliamR - looks like we are good to move forward!

Comment 5

[Liz Hull]

Twitter share copy: Plugins don’t always update automatically. Check yours now to stay safe and browse without interruption! http://mzl.la/17aqnLZ  

Facebook URL:  http://mzl.la/1z4Noqm 

Google+ URL:  http://mzl.la/1FuAhTS

Comment 6

[William Reynolds [:williamr]]

Kohei, would you like to work on this bug? It's ready to start using the content in comment 5.

We can copy how the Share button is done on the Firefox Hello page:

https://www.mozilla.org/firefox/hello/

Note that a non-Firefox user visiting the Plugin Check page will see a Firefox Download button in the top right corner. We can either find a place above or below that download button to add the Share button, or we can not show the Share button to non-Firefox users.

Comment 7

[Kohei Yoshino [:kohei]]

Yes, I'm taking this. We just need the graphic, right?

Comment 8

[William Reynolds [:williamr]]

(In reply to Kohei Yoshino [:kohei] from comment #7)
> Yes, I'm taking this. We just need the graphic, right?

Great! The graphic is not needed to work on this bug (adding social buttons), so this bug is ready to start.

The graphic is needed to update the meta tags (bug 1133145).

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: pull request

Okay, sent a PR!

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/5dde0d13bc29092d762ed3b6218a338189628fa0
Improve the Share widget, part of Bug 1131309

* Add `sky` and `mini` classes to make the styles reusable
* Make the buttons work even when JavaScript is disabled
* Fix the URL encoding
* Use `<aside>`

https://github.com/mozilla/bedrock/commit/d6d4ab6fe4f6b36d961afcf9b4b55a8d11e8d6d4
Fix Bug 1131309 - Add share buttons to 'Check your plugins' page

https://github.com/mozilla/bedrock/commit/58892a0c5ccccfed208aed6eb926db5aa0ad1728
Merge pull request #2740 from kyoshino/bug-1131309-plugincheck-share

Fix Bug 1131309 - Add share buttons to 'Check your plugins' page

Comment 11

[Kohei Yoshino [:kohei]]

Note that if a localized page doesn't have the new copy yet, the translation of the current intro will be used as the Twitter share text fallback:

> Keeping your plugins up to date helps Firefox run safely and smoothly.

Now the button is live, but looks like it's not working due to a script error, maybe in other part of the page. I'll take a look shortly.

Comment 12

[Kohei Yoshino [:kohei]]

Problem solved.