Closed
Bug 1131326
Opened 6 years ago
Closed 6 years ago
[jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to a full log
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(3 files)
6.36 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
1.26 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
1.47 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
If the log size is maxAllocationsLogLength and we have a new allocation, we drop the oldest allocation from the log. We currently do this silently, but we should inform the API consumer if any data was lost.
Assignee | ||
Updated•6 years ago
|
Summary: [jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to the log being full → [jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to a full log
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8562277 -
Flags: review?(shu)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8562278 -
Flags: review?(shu)
Comment 3•6 years ago
|
||
Comment on attachment 8562277 [details] [diff] [review] Part 0: Implement the Debugger.Memory.prototype.allocationsLogOverflowed getter Review of attachment 8562277 [details] [diff] [review]: ----------------------------------------------------------------- r=me with this documented in Debugger.Memory.md
Attachment #8562277 -
Flags: review?(shu) → review+
Updated•6 years ago
|
Attachment #8562278 -
Flags: review?(shu) → review+
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8563079 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc3b4748352b
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb18a5bf3a1c https://hg.mozilla.org/integration/mozilla-inbound/rev/67532392e5c2 https://hg.mozilla.org/integration/mozilla-inbound/rev/1cc037ffccef
Flags: in-testsuite+
Keywords: checkin-needed
Comment 7•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb18a5bf3a1c https://hg.mozilla.org/mozilla-central/rev/67532392e5c2 https://hg.mozilla.org/mozilla-central/rev/1cc037ffccef
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•