1131326 - [jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to a full log

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

If the log size is maxAllocationsLogLength and we have a new allocation, we drop the oldest allocation from the log. We currently do this silently, but we should inform the API consumer if any data was lost.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Part 0: Implement the Debugger.Memory.prototype.allocationsLogOverflowed getter

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Part 1: Test Debugger.Memory.prototype.allocationsLogOverflowed

Comment 3

[Shu-yu Guo [:shu]]

Comment on attachment 8562277 [details] [diff] [review]
Part 0: Implement the Debugger.Memory.prototype.allocationsLogOverflowed getter

Review of attachment 8562277 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with this documented in Debugger.Memory.md

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Part 2: Document Debugger.Memory.prototype.allocationsLogOverflowed

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc3b4748352b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb18a5bf3a1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/67532392e5c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cc037ffccef

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb18a5bf3a1c
https://hg.mozilla.org/mozilla-central/rev/67532392e5c2
https://hg.mozilla.org/mozilla-central/rev/1cc037ffccef