Closed Bug 1131326 Opened 5 years ago Closed 5 years ago

[jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to a full log

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(3 files)

If the log size is maxAllocationsLogLength and we have a new allocation, we drop the oldest allocation from the log. We currently do this silently, but we should inform the API consumer if any data was lost.
Summary: [jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to the log being full → [jsdbg2] Debugger.Memory's allocation log should let users know if data was lost due to a full log
Comment on attachment 8562277 [details] [diff] [review]
Part 0: Implement the Debugger.Memory.prototype.allocationsLogOverflowed getter

Review of attachment 8562277 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with this documented in Debugger.Memory.md
Attachment #8562277 - Flags: review?(shu) → review+
Attachment #8562278 - Flags: review?(shu) → review+
You need to log in before you can comment on or make changes to this bug.