1131339 - Review board slow on very large diff

Status: RESOLVED WONTFIX

(MozReview Graveyard :: General, defect)

Description

[Andrew McCreight [:mccr8]]

I'm reviewing a very large diff ( https://reviewboard.mozilla.org/r/3535/diff/0 ) and I'm noticing a number of performance problems.  This patch is entirely whitespace changes.  When I click on "hide whitespace" or whatever it is then the page hangs for multiple seconds.  Likewise, if I change the width of the browser window, the page hangs for multiple seconds.

Comment 1

[Andrew McCreight [:mccr8]]

Maybe this link works better: https://reviewboard.mozilla.org/r/3535/  "Fix indentation in docshell/base/*.cpp"

(Separately, I've also noticed a few places where the diff is slightly weird but I don't know if that's worth filing a bug for.)

Comment 2

[Gregory Szorc [:gps]]

This is almost certainly better reported as an upstream bug. https://code.google.com/p/reviewboard/issues/list I would not be surprised if it has already been filed.

FWIW, Chrome renders the page significantly faster than Nightly. Although, Chrome still stutters for a second or two. There is definitely a browser stress test here.

Comment 3

[Mark Côté [:mcote]]

The recommended process is to split large diffs like this up, which also makes reviewing easier.  In any case this is an upstream bug and probably not very easy to fix.