Closed
Bug 1131402
Opened 9 years ago
Closed 9 years ago
Collection types and how they ought to look
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: krupa.mozbugs, Assigned: kngo)
References
Details
Attachments
(1 file)
288.77 KB,
image/png
|
Details |
We are all confused about collection pages ought to look. My understanding was that - Editorial brands, Promo collections and Operator shelves have a background color in the details page - Editorial brands have a header color on the homepage - Listing collections don't have a header color in the homepage and no bg-color in the details page However, the implementation doesn't adhere to these rules. Phil, can you set the record straight for one last time? :)
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(pwalmsley)
Updated•9 years ago
|
Priority: -- → P3
Comment 1•9 years ago
|
||
The attached image should lay it all out. If it has colour on the block, that carriers over to the detail page. If it doesn't, the detail page is white/grey.
Flags: needinfo?(pwalmsley)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → kngo
Priority: P3 → P2
Assignee | ||
Comment 2•9 years ago
|
||
1. Removed color from listing collections: https://github.com/mozilla/fireplace/commit/4243143cbec381bf76efa171594601b13fa68f0a
Comment 3•9 years ago
|
||
Lotsa questions in here, but the primary one is answered, and the remaining ones have their owns bugs. Closing.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•