Closed Bug 1131436 Opened 5 years ago Closed 5 years ago

WindowsDllInterceptor is always failure with --disable-optimize and --enable-debug

Categories

(Core :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

This test on x64 doesn't pass on my build environment.

$ ../objdir-win64/toolkit/xre/test/win/TestDllInterceptor.exe
TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to add hook

0:000> g
Breakpoint 1 hit
TestDllInterceptor!mozilla::internal::WindowsDllDetourPatcher::CreateTrampoline:
00007ff6`a8fabbe0 4c894c2420      mov     qword ptr [rsp+20h],r9 ss:00000064`04fff0e8=f0f6ff0464000000

0:000> u @rdx
TestDllInterceptor!ILT+95(rotatePayload):
00007ff6`a8f91064 e987170000      jmp     TestDllInterceptor!rotatePayload (00007ff6`a8f927f0)

TestDllInterceptor!ILT+100(??8payloadQEBA_NAEBU0Z):
00007ff6`a8f91069 e9d2030000      jmp     TestDllInterceptor!payload::operator== (00007ff6`a8f91440)

...

no space to hook function.
Attached patch FixSplinter Review
Comment on attachment 8562033 [details] [diff] [review]
Fix

need analyze ILT (Incremental Link Table) style code.
Attachment #8562033 - Flags: review?(dmajor)
Attachment #8562033 - Flags: review?(dmajor) → review+
https://hg.mozilla.org/mozilla-central/rev/4491d42a2c35
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.