1131455 - about:sync-log assertion failure: newly created channel must have a loadinfo attached

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. In a Firefox debug build, try to open "about:sync-log" from the address bar.

RESULT:

BOOM! ASSERTION FAILURE!

Assertion failure: false (newly created channel must have a loadinfo attached), at mozilla/netwerk/base/nsIOService.cpp:716

#01: nsIOService::NewChannelFromURI2(nsIURI*, nsIDOMNode*, nsIPrincipal*, nsIPrincipal*, unsigned int, unsigned int, nsIChannel**)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x18ebf6]
#02: NS_NewChannelInternal(nsIChannel**, nsIURI*, nsINode*, nsIPrincipal*, nsIPrincipal*, unsigned int, unsigned int, nsILoadGroup*, nsIInterfaceRequestor*, unsigned int, nsIIOService*)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf60c9]
#03: NS_NewChannelInternal(nsIChannel**, nsIURI*, nsILoadInfo*, nsILoadGroup*, nsIInterfaceRequestor*, unsigned int, nsIIOService*)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf36c4]
#04: nsDocShell::DoURILoad(nsIURI*, nsIURI*, bool, unsigned int, nsISupports*, char const*, nsAString_internal const&, nsIInputStream*, nsIInputStream*, bool, nsIDocShell**, nsIRequest**, bool, bool, bool, nsAString_internal const&, nsIURI*, unsigned int)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d20fe7]
#05: nsDocShell::InternalLoad(nsIURI*, nsIURI*, unsigned int, nsISupports*, unsigned int, char16_t const*, char const*, nsAString_internal const&, nsIInputStream*, nsIInputStream*, unsigned int, nsISHEntry*, bool, nsAString_internal const&, nsIDocShell*, nsIUR[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2cfb8d7]
#06: nsDocShell::OnLinkClickSync(nsIContent*, nsIURI*, char16_t const*, nsAString_internal const&, nsIInputStream*, nsIInputStream*, nsIDocShell**, nsIRequest**)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d293b4]
#07: OnLinkClickEvent::Run()[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d30668]
#08: nsThread::ProcessNextEvent(bool, bool*)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0xd84c7]
#09: NS_ProcessPendingEvents(nsIThread*, unsigned int)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x107bdf]
#10: nsBaseAppShell::NativeEventCallback()[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x25247da]
#11: nsAppShell::ProcessGeckoEvents(void*)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2577cde]
#12: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x80681]
#13: __CFRunLoopDoSources0[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x7280d]
#14: __CFRunLoopRun[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x71e3f]
#15: CFRunLoopRunSpecific[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x71858]
#16: RunCurrentEventLoopInMode[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2eaef]
#17: ReceiveNextEventCommon[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2e76e]
#18: _BlockUntilNextEventMatchingListInModeWithFilter[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2e6ab]
#19: _DPSNextEvent[/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x23f81]
#20: -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x23730]
#21: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:][mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2576f76]
#22: -[NSApplication run][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x17593]
#23: nsAppShell::Run()[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2578320]
#24: nsAppStartup::Run()[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2fb7159]
#25: XREMain::XRE_mainRun()[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3022f11]
#26: XREMain::XRE_main(int, char**, nsXREAppData const*)[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x30235f2]
#27: XRE_main[mozilla/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x30239ec]
#28: main[mozilla/./objdir-osx/dist/NightlyDebug.app/Contents/MacOS/firefox +0x216b]

Comment 1

[Chris Peterson [:cpeterson]]

Christoph, I'm hitting the loadInfo assertion you added in newChannel2 bug 1113323. Will a fix for this bug need to be uplifted to Firefox 37?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1131455_about_regression_in_services.patch

(In reply to Chris Peterson [:cpeterson] from comment #1)
> Christoph, I'm hitting the loadInfo assertion you added in newChannel2 bug
> 1113323. Will a fix for this bug need to be uplifted to Firefox 37?

Chris, thanks for filing.

In fact, Bug 1087741 introduced the problem which landed on 2015-01-28 07:49:09 PST, so it's a target milestone for 38, so there is no need for uplifting the fix.

The reason the assertion was triggered is, because we did have a different instance of loadInfo on the channel that was passed off to the ioservice. What we have to do is to pass the LoadInfo passed to nsIaboutModule newChannel along to the newly created channel instead of creating a new LoadInfo.

The attached patch fixes the problem. Flagging rnewman for review since he also was the reviewer of bug 1087741, but there is no way that he could have known. Anyway, here we go.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8562397 [details] [diff] [review]
bug_1131455_about_regression_in_services.patch

Review of attachment 8562397 [details] [diff] [review]:
-----------------------------------------------------------------

I'll take your word for it!

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/087732d18dc1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/087732d18dc1