Closed Bug 1131475 Opened 5 years ago Closed 5 years ago

device_manager.js uses incorrectly cased "unable_to_toggle_FIPS" bundle key instead of correct "unable_to_toggle_fips"

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

Attachments

(1 file)

(In reply to David Keeler [:keeler] (use needinfo?) from Bug 1130405 comment #4)
> (In reply to J.C. Jones [:jcj] from comment #3)
> > > -unable_to_toggle_fips=Unable to change the FIPS mode for the security device. It is recommended that you exit and restart this application.
> > 
> > This appears to be referenced from
> > security/manager/pki/resources/content/device_manager.js:525
> 
> Good catch - I imagine these strings were intended to be the same:
> 
> https://hg.mozilla.org/mozilla-central/rev/c13b8d0a066c
> 
> Let's fix device_manager.js to use the same case.

... and fix the relevant prompting code in the process, since the bundle keys are in fact case sensitive.
I manually verified that the relevant prompt that shows up.

This patch was part of this try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79c65c11882c
Attachment #8562759 - Flags: review?(jjones)
(In reply to Cykesiopka from comment #1)
> I manually verified that the relevant prompt that shows up.

s/relevant prompt that shows up/relevant prompt now shows up/
Comment on attachment 8562759 [details] [diff] [review]
bug1131475_fix-unable_to_toggle_fips-case_v1.patch

Review of attachment 8562759 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks! r=jcj
Attachment #8562759 - Flags: review?(jjones) → review+
Thanks for the review.

(Try link is in Comment 1)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4898846a00bc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.