1131480 - Add developer option enable/disable bluetooth.snoop.enabled for bluetooth hci snoop log

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Follow up for 
* Bug 1111976  Enable/Disable Bluetooth Snoop log from Settings Developer Menu debugging options

* Bug 1131074 - Support HCI snooping with bluetoothd

Comment 1

[[e-mail]]

Talked with Shawn, He prefer name it as 'Bluetooth HCI sniffing logs to sdcard'

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1131480 to mozilla-b2g:master

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8561974 [details] [review]
[PullReq] gasolin:issue-1131480 to mozilla-b2g:master

Thanks for the patch. Please include the newly added setting in common-settings.json with a default value false.

Comment 4

[[e-mail]]

Comment on attachment 8561974 [details] [review]
[PullReq] gasolin:issue-1131480 to mozilla-b2g:master

Thanks for reminding, value added into common-settings.json.

please kindly review it again.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8561974 [details] [review]
[PullReq] gasolin:issue-1131480 to mozilla-b2g:master

r=me, thanks.

Comment 6

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/57ea408730e37e27353db74a0eeeae7e360f19da

thanks!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Gaia-try is still running, please always wait for the result before merging, thanks.