1131503 - Running csslint.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P2)

Comment 1

[[e-mail]]

I guess it will work just fine. Any suggestion to verify it?

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Hey Fred, thank you for helping this. 

However, we're not going to refactoring csslint at earlier stage since csslint is unnecessary in main building path. Developer invokes it when they try to invoke "make lint" or it will be invoked by CI.

In the other hand, csslint leverages XPCOM's DOMUtils APIs it's probably unsupported in third-party NPM package.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

You could find out what's NPM package we can use in order to replace our XPCOM linter and also provide new CSS features we need. (Or probably we can try to patch for it)

Comment 4

[Sam Foster [:sfoster] (he/him)]

CSS linter is also invoked by the pre-commit hook for the gaia repo.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:csslint-to-node > mozilla-b2g:master

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Last one piece of this big refactoring work. After landing this patch, we are able to run on pure node environment with XPCShell runtime.

It's time to deprecate b2g_sdk from Gaia and set node runtime by default once we figure out the root cause of performance issue on node.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8721657 [details] [review]
[gaia] rickychien:csslint-to-node > mozilla-b2g:master

Interesting thing is that our CSSLint was broken for a while but without any orange sign on treeherder. So I rewrote whole csslint.js and modify xfail.list to make things easy. (We don't count and print errors and warnings messages anymore)

xfail.list will be a simple blacklist from now. I've verified that submit a new PR with an error-prone CSS file will make CSSLint become orange on treeherder. It means... yeah CSSLint is back finally.

Comment 8

[Scott Wu [:scottwu]]

Comment on attachment 8721657 [details] [review]
[gaia] rickychien:csslint-to-node > mozilla-b2g:master

Looks good. Thanks! r+

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Thank you Scott!

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/99eb3b3f7a07c7152f63fe2c1da01b5092efd90c