1131521 - Running r-wrapper.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:r-wrapper-to-nodejs > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8709327 [details] [review]
[gaia] rickychien:r-wrapper-to-nodejs > mozilla-b2g:master

Here is a large patch (may be?) for build part changes. As you can see I removed build/r-wrapper.js and build/shared-utils.js from Gaia and move those logics to app's build scripts.

It has been verified on my environment and node-build-diff.sh but you could check that again and feedback any problems if you see.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

(In reply to Ricky Chien [:rickychien] from comment #2)
> Here is a large patch (may be?) for build part changes. As you can see I
> removed build/r-wrapper.js and build/shared-utils.js from Gaia and move
> those logics to app's build scripts.

For why I removed build/r-wrapper.js and build/shared-utils.js because I ran into some problems in xpcshell modules system (define at build/xpcshell-commonjs.js) when I was trying to require('./utils'); from app's build script.
However, I don't really want to dig into it since that part is going to be deprecated soon. As a result, I prefer to just extracted them and do a little bit of refactoring handily.

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8709327 [details] [review]
[gaia] rickychien:r-wrapper-to-nodejs > mozilla-b2g:master

Tested fine on device and diff looks normal. r+

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/e7232404b35502badcb8b97480788a41df2a3577