Closed Bug 1131526 Opened 9 years ago Closed 9 years ago

Running webapp-shared.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: gduan)

References

Details

Attachments

(1 file)

[gaia] cctuan:1131526 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review 
      No description provided.
Assignee: nobody → gduan
Status: NEW → ASSIGNED
Comment on attachment 8565324 [details] [review]
[gaia] cctuan:1131526 > mozilla-b2g:master

Hi Ricky,
could you review this patch? Thanks.
Attachment #8565324 - Flags: review?(ricky060709)
Comment on attachment 8565324 [details] [review]
[gaia] cctuan:1131526 > mozilla-b2g:master

Well done!!

Please fix nits leaved on Github and ensure treeheder is green. =)
Attachment #8565324 - Flags: review?(ricky060709) → review+
Thanks, 
master: https://github.com/mozilla-b2g/gaia/commit/9ef3a27cc24601152ad3e3b050aecf634900b78f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: