Closed Bug 1131573 Opened 6 years ago Closed 6 years ago

mozbrowser API : add contextmenu support to input elements in forms.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file, 1 obsolete file)

input-context.patch
6.56 KB, patch
kanru
: review+
kanru
: feedback+
Details | Diff | Splinter Review 
No description provided.
Attachment #8562074 - Flags: review?(kchen)
Comment on attachment 8562074 [details] [diff] [review]
input-context.patch

Review of attachment 8562074 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementChildPreload.js
@@ +844,5 @@
> +      // one we return the form's method and action uri.
> +      let parent = elem.parentNode;
> +      while (parent) {
> +        if (parent instanceof Ci.nsIDOMHTMLFormElement &&
> +            parent.hasAttribute("action")) {

submit button's formaction attribute could override this so you have to check that too.
Attachment #8562074 - Flags: review?(kchen) → feedback+
Attached file input-context.patch v2 (obsolete) — 
Thanks Kanru, good catch!
Attachment #8562074 - Attachment is obsolete: true
Attachment #8562127 - Flags: review?(kchen)
Attachment #8562127 - Attachment is obsolete: true
Attachment #8562127 - Attachment is patch: false
Attachment #8562127 - Flags: review?(kchen)
Comment on attachment 8562074 [details] [diff] [review]
input-context.patch

Discussing with Kanru, we finally like this one better!
Attachment #8562074 - Attachment is obsolete: false
Attachment #8562074 - Flags: review?(kchen)
Attachment #8562074 - Flags: review?(kchen) → review+
https://hg.mozilla.org/mozilla-central/rev/a0a2cc23a31c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.