1131573 - mozbrowser API : add contextmenu support to input elements in forms.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: input-context.patch

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8562074 [details] [diff] [review]
input-context.patch

Review of attachment 8562074 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementChildPreload.js
@@ +844,5 @@
> +      // one we return the form's method and action uri.
> +      let parent = elem.parentNode;
> +      while (parent) {
> +        if (parent instanceof Ci.nsIDOMHTMLFormElement &&
> +            parent.hasAttribute("action")) {

submit button's formaction attribute could override this so you have to check that too.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: input-context.patch v2

Thanks Kanru, good catch!

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8562074 [details] [diff] [review]
input-context.patch

Discussing with Kanru, we finally like this one better!

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/a0a2cc23a31c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0a2cc23a31c