Closed
Bug 1131573
Opened 6 years ago
Closed 6 years ago
mozbrowser API : add contextmenu support to input elements in forms.
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
Details
Attachments
(1 file, 1 obsolete file)
6.56 KB,
patch
|
kanru
:
review+
kanru
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8562074 -
Flags: review?(kchen)
Comment 2•6 years ago
|
||
Comment on attachment 8562074 [details] [diff] [review] input-context.patch Review of attachment 8562074 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/browser-element/BrowserElementChildPreload.js @@ +844,5 @@ > + // one we return the form's method and action uri. > + let parent = elem.parentNode; > + while (parent) { > + if (parent instanceof Ci.nsIDOMHTMLFormElement && > + parent.hasAttribute("action")) { submit button's formaction attribute could override this so you have to check that too.
Attachment #8562074 -
Flags: review?(kchen) → feedback+
Assignee | ||
Comment 3•6 years ago
|
||
Thanks Kanru, good catch!
Attachment #8562074 -
Attachment is obsolete: true
Attachment #8562127 -
Flags: review?(kchen)
Assignee | ||
Updated•6 years ago
|
Attachment #8562127 -
Attachment is obsolete: true
Attachment #8562127 -
Attachment is patch: false
Attachment #8562127 -
Flags: review?(kchen)
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8562074 [details] [diff] [review] input-context.patch Discussing with Kanru, we finally like this one better!
Attachment #8562074 -
Attachment is obsolete: false
Attachment #8562074 -
Flags: review?(kchen)
Updated•6 years ago
|
Attachment #8562074 -
Flags: review?(kchen) → review+
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/a0a2cc23a31c
Comment 6•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0a2cc23a31c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox38:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•