Closed Bug 1131576 Opened 9 years ago Closed 8 years ago

Intermittent test_windowminmaxsize.xul | Test timed out. - expected PASS

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: cbook, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1131576 - Spin the event loop between calls to showPopup in test_windowminmaxsize.xul.
58 bytes, text/x-review-board-request
enndeakin
: review+
Details 
Ubuntu VM 12.04 x64 mozilla-inbound pgo test mochitest-other

https://treeherder.mozilla.org/logviewer.html#?job_id=6444949&repo=mozilla-inbound

20:55:53 INFO - 2401 INFO TEST-UNEXPECTED-FAIL | layout/xul/test/test_windowminmaxsize.xul | Test timed out. - expected PASS
Neil, I know you authored this test case a long long time ago.  Do you have any idea why when we run this as run-by-dir (i.e. as a standalone directory) we fail?

This seems to be opt mode and we get a chunk of the tests done, we just fail to complete and get a timeout.  At first I thought this was on the popup test part:
https://dxr.mozilla.org/mozilla-central/source/layout/xul/test/test_windowminmaxsize.xul?from=test_windowminmaxsize.xul&case=true#70

as the logs showed the 1st and 3rd having output, but then I realized we must be skipping the 2nd and 4th (I could be wrong here).

Either way we are either failing there or on the next test:
https://dxr.mozilla.org/mozilla-central/source/layout/xul/test/test_windowminmaxsize.xul?from=test_windowminmaxsize.xul&case=true#177

either removing the flex attribute or waiting for focus titledPanelWindowOpened.
Depends on: 357725
Flags: needinfo?(enndeakin)
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
clearing the needinfo here
Flags: needinfo?(enndeakin)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Some investigation has shown this to be primarily caused by popup show and hide events being synchronous, starving the event loop. As a result, we process focus events from X11 much later than we should- not until after calling nsXULPopupManager::ShowPopup, which fails a check to nsXULPopupManager::MayShowPopup due to lack of window focus. I've written a patch that should fix this by spinning the event loop between calls to showPopup.
Attachment #8775306 - Flags: review?(enndeakin)
Attachment #8775306 - Flags: review?(enndeakin) → review+
Pushed by acomminos@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7577824b3e8f
Spin the event loop between calls to showPopup in test_windowminmaxsize.xul. r=enn
https://hg.mozilla.org/mozilla-central/rev/7577824b3e8f
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: