Closed Bug 1131579 Opened 7 years ago Closed 7 years ago

[e10s] Re-enable browser_visibleFindSelection.js

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This test has two issues:

1. Needs to use gBrowser.selectedBrowser.contentWindowAsCPOW
2. Checking gFindBarInitialized fails as this is flag now won't be initialized until the findbar opens
Blocks: e10s-tests
tracking-e10s: --- → +
Flags: firefox-backlog+
Assignee: nobody → enndeakin
Attached patch Fix and re-enable these tests (obsolete) — Splinter Review
Attachment #8585014 - Flags: review?(mdeboer)
Iteration: --- → 39.3 - 30 Mar
Points: --- → 1
Flags: in-testsuite+
Status: NEW → ASSIGNED
Comment on attachment 8585014 [details] [diff] [review]
Fix and re-enable these tests

Review of attachment 8585014 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Neil, thanks for working on this!

It looks good, but could you answer/ fix these points below for me?

::: browser/base/content/test/general/browser_bug567306.js
@@ +12,5 @@
> +    whenNewWindowLoaded(undefined, function (win) {
> +      whenDelayedStartupFinished(win, function () {
> +        let selectedBrowser = win.gBrowser.selectedBrowser;
> +        selectedBrowser.addEventListener("pageshow", function pageshowListener() {
> +          if (selectedBrowser.contentWindowAsCPOW.location.href == "about:blank")

Wouldn't this yield an 'unsafe CPOW usage warning' of some sorts that we're trying to get rid of?

@@ +42,3 @@
>  
> +  yield findBar.onFindCommand();
> +  

nit: superfluous spaces.

@@ +46,5 @@
>    // persisted across Fx sessions, thus not useful to test.
>    if (!HasFindClipboard)
>      is(findBar._findField.value, "Select Me", "Findbar is initialized with selection");
>    findBar.close();
> +  promiseWindowClosed(newwindow);

I think you'll want to `yield` this too...

::: browser/base/content/test/general/browser_visibleFindSelection.js
@@ +15,3 @@
>    ok(gFindBarInitialized, "find bar is now initialized");
>  
> +  // finds the div in the green box

nit: I know you didn't write this, but could you format these comments correctly?

`Finds the div in the green box.`

@@ +23,2 @@
>  
> +  // finds the div in the red box

nit: same here.
Attachment #8585014 - Flags: review?(mdeboer) → feedback+
Flags: qe-verify?
Iteration: 39.3 - 30 Mar → 40.1 - 13 Apr
Attached patch Address commentsSplinter Review
Attachment #8585014 - Attachment is obsolete: true
Flags: qe-verify? → qe-verify-
Comment on attachment 8586124 [details] [diff] [review]
Address comments

Review of attachment 8586124 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! I hope automation is just as happy about this as I am ;)

::: browser/base/content/test/general/browser_visibleFindSelection.js
@@ +15,3 @@
>    ok(gFindBarInitialized, "find bar is now initialized");
>  
> +  // Finds the div in the green box

nit: missing dot.

@@ +23,2 @@
>  
> +  // Finds the div in the red box

nit: missing dot.
Attachment #8586124 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/353ee07ef371
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.