1131579 - [e10s] Re-enable browser_visibleFindSelection.js

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Neil Deakin]

This test has two issues:

1. Needs to use gBrowser.selectedBrowser.contentWindowAsCPOW
2. Checking gFindBarInitialized fails as this is flag now won't be initialized until the findbar opens

Comment 1

[Neil Deakin]

Attachment: Fix and re-enable these tests

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8585014 [details] [diff] [review]
Fix and re-enable these tests

Review of attachment 8585014 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Neil, thanks for working on this!

It looks good, but could you answer/ fix these points below for me?

::: browser/base/content/test/general/browser_bug567306.js
@@ +12,5 @@
> +    whenNewWindowLoaded(undefined, function (win) {
> +      whenDelayedStartupFinished(win, function () {
> +        let selectedBrowser = win.gBrowser.selectedBrowser;
> +        selectedBrowser.addEventListener("pageshow", function pageshowListener() {
> +          if (selectedBrowser.contentWindowAsCPOW.location.href == "about:blank")

Wouldn't this yield an 'unsafe CPOW usage warning' of some sorts that we're trying to get rid of?

@@ +42,3 @@
>  
> +  yield findBar.onFindCommand();
> +  

nit: superfluous spaces.

@@ +46,5 @@
>    // persisted across Fx sessions, thus not useful to test.
>    if (!HasFindClipboard)
>      is(findBar._findField.value, "Select Me", "Findbar is initialized with selection");
>    findBar.close();
> +  promiseWindowClosed(newwindow);

I think you'll want to `yield` this too...

::: browser/base/content/test/general/browser_visibleFindSelection.js
@@ +15,3 @@
>    ok(gFindBarInitialized, "find bar is now initialized");
>  
> +  // finds the div in the green box

nit: I know you didn't write this, but could you format these comments correctly?

`Finds the div in the green box.`

@@ +23,2 @@
>  
> +  // finds the div in the red box

nit: same here.

Comment 3

[Neil Deakin]

Attachment: Address comments

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8586124 [details] [diff] [review]
Address comments

Review of attachment 8586124 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! I hope automation is just as happy about this as I am ;)

::: browser/base/content/test/general/browser_visibleFindSelection.js
@@ +15,3 @@
>    ok(gFindBarInitialized, "find bar is now initialized");
>  
> +  // Finds the div in the green box

nit: missing dot.

@@ +23,2 @@
>  
> +  // Finds the div in the red box

nit: missing dot.

Comment 5

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/353ee07ef371

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/353ee07ef371