Closed Bug 1131590 Opened 7 years ago Closed 7 years ago
[Shinano] Unknown network type detected: support DC-HSPA
My SIM (Orange F) is registered on a network that has DC support. Device also support it. In Gecko, however, we do not handle it, resulting in a "no data" icon being disabled when we are connected in DC mode.
Attachment #8562088 - Flags: review?(echen)
Hsin-Yi, can you help me on this ? Should I redirect review to you ?
Comment on attachment 8562088 [details] [diff] [review] Support DualCarrier r=echen Review of attachment 8562088 [details] [diff] [review]: ----------------------------------------------------------------- These two type isn't defined in AOSP standard, I was trying to figure out where is value from by checking caf's git source . But I just realized that maybe it is not from caf and could be an phone manufacturer's specific type. Since it looks like we need these types for `Shinano`, I am ok with this changes.  https://www.codeaurora.org/cgit/quic/la/platform/hardware/ril/ r=me with below comments addressed. Thank you, Alexandre. ::: dom/system/gonk/ril_worker.js @@ +4372,3 @@ > return true; > + default: > + this.context.debug("Unsupported radioTech: " + radioTech); Since this function is to check if the |radioTech| is GSM family, we don't have to print this kinds of warning, but just return true or false. @@ +6345,4 @@ > cellId.wcdmaPsc = this.parseInt(cid, -1, 16); > break; > + default: > + this.context.debug("Unsupported radioTech: " + radioTech); Ditto. We already filter out the unsupported radio tech by checking |_isGsmTechGroup| , don't have to print any warning here.  https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#6299-6303
Attachment #8562088 - Flags: review?(echen) → review+
Attachment #8562088 - Attachment is obsolete: true
Comment on attachment 8564039 [details] [diff] [review] Support DualCarrier r=echen Carrying r+ Edgar, do you mind pushing this for me ? I'm gonna be out of network for a little while and I'd like this to land soon :). Thanks!
Attachment #8564039 - Flags: review+
b2g-inbound is closed now. :( I will try pushing it later.
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in before you can comment on or make changes to this bug.