Closed Bug 1131653 Opened 5 years ago Closed 5 years ago

[Bluetooth] Move profile helper classes to manager namespaces

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
2.2 S6 (20feb)
Tracking Status
firefox38 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(4 files)

While working on bug 1126720, I found out that several helper classes for profile managers conflict with each other and lead to linker bugs. These classes have the same symbol name, but do different things. The linker will pick only one of them, which leads to corrupt binaries.
Comment on attachment 8562152 [details] [diff] [review]
[01] Bug 1131653: Move Handsfree helper classes into BluetoothHandsfreeManager namespace

Review of attachment 8562152 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562152 - Flags: review?(btian) → review+
Comment on attachment 8562153 [details] [diff] [review]
[02] Bug 1131653: Move A2DP/AVRCP helper classes into BluetoothA2dpManager namespace

Review of attachment 8562153 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562153 - Flags: review?(btian) → review+
Comment on attachment 8562154 [details] [diff] [review]
[03] Bug 1131653: Move OPP helper classes into BluetoothOppManager namespace

Review of attachment 8562154 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8562154 - Flags: review?(btian) → review+
Comment on attachment 8562155 [details] [diff] [review]
[04] Bug 1131653: Move GATT helper classes to BluetoothGattManager namespace

Review of attachment 8562155 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for revising it.
Attachment #8562155 - Flags: review?(btian) → review+
You need to log in before you can comment on or make changes to this bug.