1131665 - [Contacts] Update Carets

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Pang [:epang] UX]

The carets need to be updated in Contacts > Settings > Ice Contacts.  See attached image.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot from Device

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] pivanov:bug-1131665 > mozilla-b2g:master

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8563643 [details] [review]
patch for Gaia/master

They don't look right in your screenshot, but looks right when I applied the patch, so R+.  Thanks!

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8563643 [details] [review]
patch for Gaia/master

as this is a global change I would suggest you ask Wilson or other BB owner for a review 

thanks!

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8563643 [details] [review]
patch for Gaia/master

I was under the impression SVG was off limits. Has this rule-of-thumb changed?

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I think so ... we use a lot of SVGs in /shared/style/

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8563643 [details] [review]
patch for Gaia/master

Vivien says it's fine :)

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/83eea7ca6b17cf29ef6259b90cab20370dc86d9e

Comment 10

[James Burke [:jrburke]]

Comment on attachment 8563643 [details] [review]
patch for Gaia/master

[Approval Request Comment]
Bug 1118893 is 2.2+ and this changeset provides the shared image used for that bug fix. All the bugs off of the meta bug 1131641 for new carats should land on 2.2. 

[Bug caused by] (feature/regressing bug #):
Change desired for RTL to have indicators that there are sub-screens, but without the bigger thicker carats used before, tracked in meta bug 1131641.

[User impact] if declined:
The desired look of these carats will not be part of the RTL effort.

[Testing completed]:
Just CSS/image changes, received ui-review+.

[Risk to taking this patch] (and alternatives if risky):
Very low, just a CSS/image change.

[String changes made]:
None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8092cb3a74d5dd67f5dd7ad61cf9633d92fc036f

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual results:  There Contacts app uses the newer smaller carat symbol.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150227010229
Gaia: 7512026a377271a0cade12d70846557f0bc7781c
Gecko: c7968255c1ea
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150227002521
Gaia: eb6a5ac9081d3962198e0f4520b0743d716d7a27
Gecko: c8a38dcfbebc
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0