Closed
Bug 1131741
Opened 9 years ago
Closed 9 years ago
Implement nsISupports in ObserverDelegee to workaround bug 1131317
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
We're likely to fix bug 1131317 in the platform but we might as well do the simple workaround in the SDK too as well as take the SDK specific test I wrote a while back. This looks like it will fix a lot of the panel intermittent oranges.
Attachment #8562273 -
Flags: review?(evold)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dtownsend
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8562273 [details] [review] pull request This looks good thanks! I only r- for a few small test changes, to make the test async, the other stuff is just me nitpicking.
Attachment #8562273 -
Flags: review?(evold) → review-
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8562273 [details] [review] pull request Updated from the comments
Attachment #8562273 -
Flags: review- → review?(evold)
|
|
||
Updated•9 years ago
|
Attachment #8562273 -
Flags: review?(evold) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/0aa270ada80c70c1690c9befedf917eca7555d7b Bug 1094392: Make ObserverDelegee implement nsISupports to keep it from being garbage collected.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•