1131763 - Remove dead constants

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[David Burns :automatedtester]

The const in https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#31-38 don't appear to be used so we might as well remove them. Once removed we will need to run tests and push to try

Run tests wiht the following command
./mach marionette-tests # runs tests

Run against try incase there is some dependency that is using them

Try syntax
'try: -b do -p linux,macosx64,macosx64_gecko,win32,linux_gecko,linux64_gecko,linux64-mulet -u marionette,marionette-webapi,gaia-ui-test,gaia-integration,web-platform-tests,crashtest-1,crashtest-2,crashtest-3,reftest-1,reftest-2,reftest-3,reftest-4,reftest-5,reftest-6,reftest-7,reftest-8,reftest-9,reftest-10,reftest-11,reftest-12,reftest-13,reftest-14,reftest-15,reftest-16,reftest-17,reftest-18,reftest-19,reftest-20 -t none'"

Comment 1

[Boris Kudryavtsev [:bkudryavtsev]]

Tests finished with one unrelated error:

ERROR test_selectioncarets.py SelectionCaretsTest.test_contenteditable2_minimum_select_one_character

There were also 2 failed tests involving test_selectioncarets.py

The results of the test were the same with and without the constants. 

Should I submit the patch?

Comment 2

[David Burns :automatedtester]

Hey Boris, 

yes please, I will run the tests locally anyway. Thanks for the patch!

Comment 3

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev1 - Removes unused constants

Comment 4

[David Burns :automatedtester]

Thanks for doing this! I really appreciate your effort! We have more good first bugs at https://wiki.mozilla.org/Auto-tools/Projects/Marionette/Auto-tools/Projects/Marionette/Roadmap#Good_First_Bugs if you are looking for more!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/492a04a7efc4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/492a04a7efc4

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.