1131782 - [Camera][Gecko][Shinano] Camera supports ISO modes under a different parameter key

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

The ISO-equivalent sensitivity setting is not an AOSP standard parameter, so to expose it on, e.g., Flame, we need to use a raw string key[1][2].

1. https://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraParameters.cpp#107
2. https://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraParameters.cpp#163

Shinano uses different key strings entirely, so we will need to update GonkCameraParameters to detect this and use the appropriate key string.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Add runtime support for detecting vendor-specific parameter keys, v1

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8562952 [details] [diff] [review]
Add runtime support for detecting vendor-specific parameter keys, v1

Review of attachment 8562952 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/b2g-inbound/rev/411fdc70f98c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/411fdc70f98c