Closed Bug 1131791 Opened 7 years ago Closed 7 years ago

Assert that bool(parent()) == is<GlobalObject>() when using the latter

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
flash10

People

(Reporter: terrence, Unassigned)

References

Details

There are a number of places in gecko that use JS_GetParent(obj) == nullptr to check if an object is a global, instead of calling JS_IsGlobalObject(obj). We should assert that these are the same so that we can confidently update the callers for bug 805052.
js_fun_bind appears to be using the parent of the CallObject as a place to store the target JSFunction. We'll need to move this to a slot.
Depends on: 1131855
Tehre's no more JS_GetParent or parents, so not much to do here.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.