Closed Bug 1131796 Opened 9 years ago Closed 9 years ago

do not explicitly parent expando object to the proxy's parent

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: sfink, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Don't parent the DOM proxy expando object to the proxy
1.20 KB, patch
peterv
: review+
Details | Diff | Splinter Review 
Split out from bug 805052, item 8: DOMProxyHandler::EnsureExpandoObject which parents the expando object to the proxy itself. I[bz] don't think it should.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Summary: do not parent expando object to the proxy → do not parent expando object to the proxy's parent
Actually, we're parenting to the proxy's parent, but since that's the global, that's the same thing as not passing a parent at all.
Summary: do not parent expando object to the proxy's parent → do not explicitly parent expando object to the proxy's parent
Attachment #8562475 - Flags: review?(peterv) → review+
The problem was bug 1117242.  Repushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/1765edeb1379
Flags: needinfo?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/1765edeb1379
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: