Closed Bug 1131803 Opened 7 years ago Closed 7 years ago

remove use of parent SandboxCallableProxyHandler

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: sfink, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Split out from bug 805052, item 5: SandboxCallableProxyHandler::call -- it uses a custom parent for a proxy to store another object, and Parent() in XPCShell returns the parent
Blocks: 1136925
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8569479 [details] [diff] [review]
Remove the use of parents from SandboxCallableProxyHandler and SandboxProxyHandler

Review of attachment 8569479 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/Sandbox.cpp
@@ +639,5 @@
>  {
>      MOZ_ASSERT(JS::IsCallable(callable));
>      // Our proxy is wrapping the callable.  So we need to use the
> +    // callable as the private.  We put the given sandboxProtoProxy in
> +    // an extra slot,, and our call() hook depends on that.

s/,,/,/
Attachment #8569479 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/eed045e1478f
https://hg.mozilla.org/mozilla-central/rev/dc3c7c5d75a7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.