1131803 - remove use of parent SandboxCallableProxyHandler

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Steve Fink [:sfink] [:s:]]

Split out from bug 805052, item 5: SandboxCallableProxyHandler::call -- it uses a custom parent for a proxy to store another object, and Parent() in XPCShell returns the parent

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the use of parents from SandboxCallableProxyHandler and SandboxProxyHandler

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8569479 [details] [diff] [review]
Remove the use of parents from SandboxCallableProxyHandler and SandboxProxyHandler

Review of attachment 8569479 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/Sandbox.cpp
@@ +639,5 @@
>  {
>      MOZ_ASSERT(JS::IsCallable(callable));
>      // Our proxy is wrapping the callable.  So we need to use the
> +    // callable as the private.  We put the given sandboxProtoProxy in
> +    // an extra slot,, and our call() hook depends on that.

s/,,/,/

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef990c3d69d and then https://hg.mozilla.org/integration/mozilla-inbound/rev/b590778549ab to actually like ... address the review comment.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed these out in:
https://hg.mozilla.org/integration/mozilla-inbound/rev/351ff671a301
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dac945cae32

As I grasp at straws to figure out what broke mochitest-e10s-dt today:
https://treeherder.mozilla.org/logviewer.html#?job_id=7050990&repo=mozilla-inbound

Comment 5

[Boris Zbarsky [:bzbarsky]]

Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/eed045e1478f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc3c7c5d75a7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eed045e1478f
https://hg.mozilla.org/mozilla-central/rev/dc3c7c5d75a7