1131816 - [e10s] Enable link saving tests

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: test-fixes

This would help to find regressions like bug 1127927.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8562375 [details] [diff] [review]
test-fixes

Review of attachment 8562375 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but I'm going to wait until the questions in bug 1131818 are resolved before r+'ing.

Comment 2

[:Gijs (he/him)]

Did this get lost? :-)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8562375 [details] [diff] [review]
test-fixes

Review of attachment 8562375 [details] [diff] [review]:
-----------------------------------------------------------------

Hey billm, sorry about the delay here. This completely fell off the map.

This looks fine, but we'll probably want to use the BTU mouse synth utilities instead of AsyncUtils.

::: browser/base/content/test/general/browser_save_link-perwindowpb.js
@@ +30,5 @@
>        aWindow.document.addEventListener("popupshown", contextMenuOpened, false);
>  
>        var link = testBrowser.contentDocument.getElementById("fff");
>        info("link: " + link);
> +      AsyncUtils.synthesizeMouseAtCenter(link,

This should probably use BrowserTestUtils.synthesizeMouseAtCenter

::: browser/base/content/test/general/browser_save_private_link_perwindowpb.js
@@ +102,5 @@
>  
>        waitForFocus(function () {
>          aWindow.document.addEventListener("popupshown", contextMenuOpened, false);
>          var img = aWindow.gBrowser.selectedBrowser.contentDocument.getElementById("img");
> +        AsyncUtils.synthesizeMouseAtCenter(img,

BrowserTestUtils.synthesizeMouseAtCenter

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This has all been superseded.